This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: ppc64le: Add nvdimm to defaultQemuMachineOption #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 66.87% 66.87%
=======================================
Files 85 85
Lines 9107 9107
=======================================
Hits 6090 6090
Misses 2383 2383
Partials 634 634 |
|
Build succeeded (third-party-check pipeline).
|
nvdimm is fundamental to get rootfs approach working for Kata Containers on ppc64le. It should be added to the default qemu machine option list. Fixes: #561 Signed-off-by: Nitesh Konkar [email protected]
|
PSS Measurement: Memory inside container: |
|
Build succeeded (third-party-check pipeline).
|
grahamwhaley
approved these changes
Aug 9, 2018
There was a problem hiding this comment.
lgtm
I see over on the amd64 file there is an NVDIMM mention also in the appendImage func (
runtime/virtcontainers/qemu_amd64.go
Line 138 in ef3a7e8
|
@nitkon since this PR fixes Qemu for ppc64, please backport it to stable branches. |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
Fix spelling mistakes and formatting issues. Fixes kata-containers#562. Signed-off-by: James O. D. Hunt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvdimm is fundamental to get rootfs approach
working for Kata Containers on ppc64le. It should
be added to the default qemu machine option list.
Fixes: #561
Signed-off-by: Nitesh Konkar [email protected]