Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

NEMU: Disable default hugepages enabling for virtio-fs #1780

Merged

Conversation

ganeshmaharaj
Copy link
Contributor

hugepages were enbled by default on NEMU to allow use of virtio-fs. kata
now has a change where virtio-fs will default to use /dev/shm as the
shared memory file backing location. With that, we should be able to
disable default hugepages for NEMU

Fixes: #1775
Signed-off-by: Ganesh Maharaj Mahalingam [email protected]
(cherry picked from commit a75db86)

hugepages were enbled by default on NEMU to allow use of virtio-fs. kata
now has a change where virtio-fs will default to use /dev/shm as the
shared memory file backing location. With that, we should be able to
disable default hugepages for NEMU

Fixes: kata-containers#1775
Signed-off-by: Ganesh Maharaj Mahalingam <[email protected]>
(cherry picked from commit a75db86)
@ganeshmaharaj
Copy link
Contributor Author

/test

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #1780 into stable-1.7 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           stable-1.7    #1780   +/-   ##
===========================================
  Coverage       53.92%   53.92%           
===========================================
  Files             106      106           
  Lines           13142    13142           
===========================================
  Hits             7087     7087           
  Misses           5206     5206           
  Partials          849      849

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devimc devimc merged commit 82c547b into kata-containers:stable-1.7 Jun 10, 2019
@ganeshmaharaj ganeshmaharaj deleted the bp-nemu-virtiofs-hugepages branch July 17, 2019 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants