Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Add missing docs #1682

Merged
merged 2 commits into from
May 20, 2019
Merged

Conversation

jodh-intel
Copy link
Contributor

Add a few minimal documents to allow all the documentation in this repository to be navigated from the top-level README.

Fixes #1681.

Signed-off-by: James O. D. Hunt [email protected]

Use a markdown link rather than a URL for virtcontainers docs.

Signed-off-by: James O. D. Hunt <[email protected]>
Add a few minimal documents to allow all the documentation in this
repository to be navigated from the top-level README.

Fixes kata-containers#1681.

Signed-off-by: James O. D. Hunt <[email protected]>
@jodh-intel jodh-intel requested a review from a team as a code owner May 15, 2019 15:29
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Contributor

/test

@jodh-intel
Copy link
Contributor Author

@marcov - could you tal please? This is a doc-only PR so I think we can merge once we have one more ack ;)

@jodh-intel
Copy link
Contributor Author

Thanks @marcov.

@grahamwhaley - looks like the zuul checks have stalled?

@grahamwhaley
Copy link
Contributor

hmm, @jodh-intel once in a while we see a stall, and then they magically appear (they do have some sort of priority queue on the zuul CI node infra, but just once in a while we see them get stuck, maybe at a particularly busy time). Still, Monday morning I would not think to be that busy. Maybe there is some other issue. Give it 1h, and then I'll come and check and see what I can find.

@grahamwhaley
Copy link
Contributor

@jodh-intel yep, i think Zuul things have stalled.
Looking at https://zuul.opendev.org/t/kata-containers/builds?pipeline=SoB-check - we have had 3 SoB checks run today.
If we clear the filter, we've only had 5 items run https://zuul.opendev.org/t/kata-containers/builds today.
I don't see any issues on the status page, but nor do I know how well that ties into the higher levels of infra.
/cc @ttx @cboylan - any known issues with Zull infra, github, Kata at present?

@jodh-intel
Copy link
Contributor Author

@grahamwhaley - It's still blocked :(

We really need to find a way to force-override issues like this. Is there anything we can do aside from restart all the CI tests I wonder?

@grahamwhaley
Copy link
Contributor

¯\_(ツ)_/¯ - 'required' CIs are by definition required, and all CIs have their moments of being flaky. It's not just Zuul, we've had this with Jenkins and Travis and semaphore and pullapprove. It's literally only been a few hours - let the west coast wake up and see where we get to.

@jodh-intel
Copy link
Contributor Author

@grahamwhaley - I was waiting for that response. Yes. I do get that 😄 But -- as we're seeing -- the world is not always perfect and we (well, some of us) need a way to bypass the automatic checks when problems occur. These two particular checks which are blocking a trivial doc-only PR are themselves trivial and could easily be manually by simply looking at the commits at worst. But that doesn't work today - we have to wait, wait, waaaaaaaaait...

@jodh-intel
Copy link
Contributor Author

RHEL 7 CI failing with a consistent network timeout issue:

time="2019-05-16T10:56:06Z" level=error msg="error copying docker://quay.io/crio/redis:alpine to dir:/tmp/jenkins/workspace/kata-containers-runtime-rhel-7-PR/go/src/github.com/cri-o/cri-o/.artifacts/redis-image: Error reading blob sha256:ff3a5c916c92643ff77519ffa742d3ec61b7f591b6b7504599d95a4a41134e28
    :  
dial tcp 13.32.84.96:443: i/o timeout" 
Error pulling quay.io/crio/redis

@cboylan
Copy link

cboylan commented May 20, 2019

¯\_(ツ)_/¯ - 'required' CIs are by definition required, and all CIs have their moments of being flaky. It's not just Zuul, we've had this with Jenkins and Travis and semaphore and pullapprove. It's literally only been a few hours - let the west coast wake up and see where we get to.

I'm not seeing any zuul specific issues that would lead to this. Things that may cause this are zuul restarts (to pick up new code) where we'd lose the event(s) but zuul has been running since the 16th.

There is also the possibility that we've amassed a large github event processing backlog due to activity and deficiencies where you cannot lookup a PR by commit and must instead scan all PRs for commits, but I don't see indication of that in our logs.

Usually it is a great help if you can provide specific examples of where things are unhappy then we can track those specific examples down in logs. What PR(s) have been slow to be DCO checked today?

@jodh-intel
Copy link
Contributor Author

Hi @cboylan - this PR is the only one I've noticed but maybe others have more info...?

@cboylan
Copy link

cboylan commented May 20, 2019

zuul-recheck

@cboylan
Copy link

cboylan commented May 20, 2019

/zuul-recheck

@jodh-intel
Copy link
Contributor Author

@cboylan - thanks! I'll have to remember that one... ;)

@cboylan
Copy link

cboylan commented May 20, 2019

Ok I think that Zuul either missed these events or there were github errors when trying to process them a few days back. The recheck seems to have worked fine once I Figured out the correct string to use there. (I'm told by other zuul + github users that if github is having a sad then zuul may eventually give up retrying and effectively lose an event).

Hopefully this gets you moving again. In general I think it is safe to try a recheck if you don't see anything queued up for a PR in the status page. Also Zuul will dedup anyway so safe to over recheck too.

@jodh-intel
Copy link
Contributor Author

Nice - thanks again @cboylan.

@grahamwhaley
Copy link
Contributor

:-) It is documented on the SoB wiki page in the section this-looks-like-a-transient-failure-how-can-i-ask-the-tests-to-run-again :-) - but, yeah, you don't get a link to the wiki pages on this PR if Zuul has failed to feed back at all - the trick is to remember you can find the link from another PR that has triggered ;-)

@jodh-intel
Copy link
Contributor Author

SoB! I forgot to check the SoB wiki :)

/me sobs...

@jodh-intel jodh-intel merged commit 0fce78c into kata-containers:master May 20, 2019
zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
This updates grpc-go vendor package to v1.11.3 release, to fix server.Stop()
handling so that server.Serve() does not wait blindly.

Full commit list:
d11072e (tag: v1.11.3) Change version to 1.11.3
d06e756 clientconn: add support for unix network in DialContext. (kata-containers#1883)
452c2a7 Change version to 1.11.3-dev
d89cded (tag: v1.11.2) Change version to 1.11.2
98ac976 server: add grpc.Method function for extracting method from context (kata-containers#1961)
0f5fa28 Change version to 1.11.2-dev
1e2570b (tag: v1.11.1) Change version to 1.11.1
d28faca client: Fix race when using both client-side default CallOptions and per-call CallOptions (kata-containers#1948)
48b7669 Change version to 1.11.1-dev
afc05b9 (tag: v1.11.0) Change version to 1.11.0
f2620c3 resolver: keep full unparsed target string if scheme in parsed target is not registered (kata-containers#1943)
9d2250f status: rename Status to GRPCStatus to avoid name conflicts (kata-containers#1944)
2756956 status: Allow external packages to produce status-compatible errors (kata-containers#1927)
0ff1b76 routeguide: reimplement distance calculation
dfbefc6 service reflection can lookup enum, enum val, oneof, and field symbols (kata-containers#1910)
32d9ffa Documentation: Fix broken link in rpc-errors.md (kata-containers#1935)
d5126f9 Correct Go 1.6 support policy (kata-containers#1934)
5415d18 Add documentation and example of adding details to errors (kata-containers#1915)
57640c0 Allow storing alternate transport.ServerStream implementations in context (kata-containers#1904)
031ee13 Fix Test: Update the deadline since small deadlines are prone to flakes on Travis. (kata-containers#1932)
2249df6 gzip: Add ability to set compression level (kata-containers#1891)
8124abf credentials/alts: Remove the enable_untrusted_alts flag (kata-containers#1931)
b96718f metadata: Fix bug where AppendToOutgoingContext could modify another context's metadata (kata-containers#1930)
738eb6b fix minor typos and remove grpc.Codec related code in TestInterceptorCanAccessCallOptions (kata-containers#1929)
211a7b7 credentials/alts: Update ALTS "New" APIs (kata-containers#1921)
fa28bef client: export types implementing CallOptions for access by interceptors (kata-containers#1902)
ec9275b travis: add Go 1.10 and run vet there instead of 1.9 (kata-containers#1913)
13975c0 stream: split per-attempt data from clientStream (kata-containers#1900)
2c2d834 stats: add BeginTime to stats.End (kata-containers#1907)
3a9e1ba Reset ping strike counter right before sending out data. (kata-containers#1905)
90dca43 resolver: always fall back to default resolver when target does not follow URI scheme (kata-containers#1889)
9aba044 server: Convert all non-status errors to codes.Unknown (kata-containers#1881)
efcc755 credentials/alts: change ALTS protos to match the golden version (kata-containers#1908)
0843fd0 credentials/alts: fix infinite recursion bug [in custom error type] (kata-containers#1906)
207e276 Fix test race: Atomically access minConnecTimout in testing environment. (kata-containers#1897)
3ae2a61 interop: Add use_alts flag to client and server binaries (kata-containers#1896)
5190b06 ALTS: Simplify "New" APIs (kata-containers#1895)
7c5299d Fix flaky test: TestCloseConnectionWhenServerPrefaceNotReceived (kata-containers#1870)
f0a1202 examples: Replace context.Background with context.WithTimeout (kata-containers#1877)
a1de3b2 alts: Change ALTS proto package name (kata-containers#1886)
2e7e633 Add ALTS code (kata-containers#1865)
583a630 Expunge error codes that shouldn't be returned from library (kata-containers#1875)
2759199 Small spelling fixes (unknow -> unknown) (kata-containers#1868)
12da026 clientconn: fix a typo in GetMethodConfig documentation (kata-containers#1867)
dfa1834 Change version to 1.11.0-dev (kata-containers#1863)
46fd263 benchmarks: add flag to benchmain to use bufconn instead of network (kata-containers#1837)
3926816 addrConn: Report underlying connection error in RPC error (kata-containers#1855)
445b728 Fix data race in TestServerGoAwayPendingRPC (kata-containers#1862)
e014063 addrConn: keep retrying even on non-temporary errors (kata-containers#1856)
484b3eb transport: fix race causing flow control discrepancy when sending messages over server limit (kata-containers#1859)
6c48c7f interop test: Expect io.EOF from stream.Send() (kata-containers#1858)
08d6261 metadata: provide AppendToOutgoingContext interface (kata-containers#1794)
d50734d Add status.Convert convenience function (kata-containers#1848)
365770f streams: Stop cleaning up after orphaned streams (kata-containers#1854)
7646b53 transport: support stats.Handler in serverHandlerTransport (kata-containers#1840)
104054a Fix connection drain error message (kata-containers#1844)
d09ec43 Implement unary functionality using streams (kata-containers#1835)
37346e3 Revert "Add WithResolverUserOptions for custom resolver build options" (kata-containers#1839)
424e3e9 Stream: do not cancel ctx created with service config timeout (kata-containers#1838)
f9628db Fix lint error and typo (kata-containers#1843)
0bd008f stats: Fix bug causing trailers-only responses to be reported as headers (kata-containers#1817)
5769e02 transport: remove unnecessary rstReceived (kata-containers#1834)
0848a09 transport: remove redundant check of stream state in Write (kata-containers#1833)
c22018a client: send RST_STREAM on client-side errors to prevent server from blocking (kata-containers#1823)
82e9f61 Use keyed fields for struct initializers (kata-containers#1829)
5ba054b encoding: Introduce new method for registering and choosing codecs (kata-containers#1813)
4f7a2c7 compare atomic and mutex performance in case of contention. (kata-containers#1788)
b71aced transport: Fix a data race when headers are received while the stream is being closed (kata-containers#1814)
46bef23 Write should fail when the stream was done but context wasn't cancelled. (kata-containers#1792)
10598f3 Explain target format in DialContext's documentation (kata-containers#1785)
08b7bd3 gzip: add Name const to avoid typos in usage (kata-containers#1804)
8b02d69 remove .please-update (kata-containers#1800)
1cd2346 Documentation: update broken wire.html link in metadata package. (kata-containers#1791)
6913ad5 Document that all errors from RPCs are status errors (kata-containers#1782)
8a8ac82 update const order (kata-containers#1770)
e975017 Don't set reconnect parameters when the server has already responded. (kata-containers#1779)
7aea499 credentials: return Unavailable instead of Internal for per-RPC creds errors (kata-containers#1776)
c998149 Avoid copying headers/trailers in unary RPCs unless requested by CallOptions (kata-containers#1775)
8246210 Update version to 1.10.0-dev (kata-containers#1777)
17c6e90 compare atomic and mutex performance for incrementing/storing one variable (kata-containers#1757)
65c901e Fix flakey test. (kata-containers#1771)
7f2472b grpclb: Remove duplicate init() (kata-containers#1764)
09fc336 server: fix bug preventing Serve from exiting when Listener is closed (kata-containers#1765)
035eb47 Fix TestGracefulStop flakiness (kata-containers#1767)
2720857 server: fix race between GracefulStop and new incoming connections (kata-containers#1745)
0547980 Notify parent ClientConn to re-resolve in grpclb (kata-containers#1699)
e6549e6 Add dial option to set balancer (kata-containers#1697)
6610f9a Fix test: Data race while resetting global var. (kata-containers#1748)
f4b5237 status: add Code convenience function (kata-containers#1754)
47bddd7 vet: run golint on _string files (kata-containers#1749)
45088c2 examples: fix concurrent map accesses in route_guide server (kata-containers#1752)
4e393e0 grpc: fix deprecation comments to conform to standard (kata-containers#1691)
0b24825 Adjust keepalive paramenters in the test such that scheduling delays don't cause false failures too often. (kata-containers#1730)
f9390a7 fix typo (kata-containers#1746)
6ef45d3 fix stats flaky test (kata-containers#1740)
98b17f2 relocate check for shutdown in ac.tearDown() (kata-containers#1723)
5ff10c3 fix flaky TestPickfirstOneAddressRemoval (kata-containers#1731)
2625f03 bufconn: allow readers to receive data after writers close (kata-containers#1739)
b0e0950 After sending second goaway close conn if idle. (kata-containers#1736)
b8cf13e Make sure all goroutines have ended before restoring global vars. (kata-containers#1732)
4742c42 client: fix race between server response and stream context cancellation (kata-containers#1729)
8fba5fc In gracefull stop close server transport only after flushing status of the last stream. (kata-containers#1734)
d1fc8fa Deflake tests that rely on Stop() then Dial() not reconnecting (kata-containers#1728)
dba60db Switch balancer to grpclb when at least one address is grpclb address (kata-containers#1692)
ca1b23b Update CONTRIBUTING.md to CNCF CLA
2941ee1 codes: Add UnmarshalJSON support to Code type (kata-containers#1720)
ec61302 naming: Fix build constraints for go1.6 and go1.7 (kata-containers#1718)
b8191e5 remove stringer and go generate (kata-containers#1715)
ff1be3f Add WithResolverUserOptions for custom resolver build options (kata-containers#1711)
580defa Fix grpc basics link in route_guide example (kata-containers#1713)
b7dc71e Optimize codes.String() method using a switch instead of a slice of indexes (kata-containers#1712)
1fc873d Disable ccBalancerWrapper when it is closed (kata-containers#1698)
bf35f1b Refactor roundrobin to support custom picker (kata-containers#1707)
4308342 Change parseTimeout to not handle non-second durations (kata-containers#1706)
be07790 make load balancing policy name string case-insensitive (kata-containers#1708)
cd563b8 protoCodec: avoid buffer allocations if proto.Marshaler/Unmarshaler (kata-containers#1689)
61c6740 Add comments to ClientConn/SubConn interfaces to indicate new methods may be added (kata-containers#1680)
ddbb27e client: backoff before reconnecting if an HTTP2 server preface was not received (kata-containers#1648)
a4bf341 use the request context with net/http handler (kata-containers#1696)
c6b4608 transport: fix race sending RPC status that could lead to a panic (kata-containers#1687)
00383af Fix misleading default resolver scheme comments (kata-containers#1703)
a62701e Eliminate data race in ccBalancerWrapper (kata-containers#1688)
1e1a47f Re-resolve target when one connection becomes TransientFailure (kata-containers#1679)
2ef021f New grpclb implementation (kata-containers#1558)
10873b3 Fix panics on balancer and resolver updates (kata-containers#1684)
646f701 Change version to 1.9.0-dev (kata-containers#1682)

Fixes: kata-containers#307

Signed-off-by: Peng Tao <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing documentation
5 participants