Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

snap: add snapcraft store banner #1199

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

devimc
Copy link

@devimc devimc commented Jan 30, 2019

add snapcraft store banner

fixes #1198

Signed-off-by: Julio Montes [email protected]

@devimc devimc requested a review from a team as a code owner January 30, 2019 21:42
@devimc
Copy link
Author

devimc commented Jan 30, 2019

Preview

screenshot from 2019-01-30 15-43-38

GabyCT
GabyCT previously approved these changes Jan 30, 2019
Copy link

@intelkevinputnam intelkevinputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sboeuf sboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with having this banner somewhere, but it'd be more appropriate in a subsection such as Downloads or Where to get it, instead of being the first thing in our Readme.

@egernst please give us your opinion on this one.

@egernst
Copy link
Member

egernst commented Jan 31, 2019

agreed re: @sboeuf comments on location.

@jodh-intel
Copy link
Contributor

I agree that it's a little too prominent right at the top. It's a shame you can't make it "float right".

Also, any plans to add it to https://github.com/kata-containers/documentation/tree/master/install ?

@devimc devimc dismissed stale reviews from intelkevinputnam and GabyCT via 8d4e2e7 January 31, 2019 13:31
@devimc devimc force-pushed the topic/snapBanner branch 2 times, most recently from 8d4e2e7 to 0e0b0c1 Compare January 31, 2019 13:34
@devimc
Copy link
Author

devimc commented Jan 31, 2019

@sboeuf @egernst @jodh-intel done

screenshot from 2019-01-31 07-35-29

@jodh-intel
Copy link
Contributor

@devimc - thanks for updating. This feels a bit odd to me now though as the new "Downloads" section is channeling users down a single path ("snap only") whereas we do want to highlight that the user has options.

I think having a "Downloads" section here is useful, but that should point users at https://github.com/kata-containers/documentation/tree/master/install.

So, why don't we:

  • Rename "Quick start for users" to "Download and install"
  • Add the snapcraft icon in that section.

Also note that you need to update the TOC at the top of the doc.

@devimc
Copy link
Author

devimc commented Jan 31, 2019

@jodh-intel done

@jcvenegas
Copy link
Member

@devimc seems that still need to update the index

add snapcraft store banner

fixes kata-containers#1198

Signed-off-by: Julio Montes <[email protected]>
@devimc
Copy link
Author

devimc commented Feb 1, 2019

@jcvenegas good catch!, fixed

@devimc
Copy link
Author

devimc commented Feb 1, 2019

/test

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @devimc.

@devimc devimc merged commit f92ca1d into kata-containers:master Feb 5, 2019
@egernst egernst mentioned this pull request Feb 26, 2019
@devimc devimc deleted the topic/snapBanner branch April 8, 2019 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add snap store banner
8 participants