-
Notifications
You must be signed in to change notification settings - Fork 374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with having this banner somewhere, but it'd be more appropriate in a subsection such as Downloads
or Where to get it
, instead of being the first thing in our Readme.
@egernst please give us your opinion on this one.
agreed re: @sboeuf comments on location. |
I agree that it's a little too prominent right at the top. It's a shame you can't make it "float right". Also, any plans to add it to https://github.com/kata-containers/documentation/tree/master/install ? |
8d4e2e7
to
0e0b0c1
Compare
@sboeuf @egernst @jodh-intel done |
@devimc - thanks for updating. This feels a bit odd to me now though as the new "Downloads" section is channeling users down a single path ("snap only") whereas we do want to highlight that the user has options. I think having a "Downloads" section here is useful, but that should point users at https://github.com/kata-containers/documentation/tree/master/install. So, why don't we:
Also note that you need to update the TOC at the top of the doc. |
0e0b0c1
to
94655d8
Compare
@jodh-intel done |
@devimc seems that still need to update the index |
add snapcraft store banner fixes kata-containers#1198 Signed-off-by: Julio Montes <[email protected]>
94655d8
to
7222f53
Compare
@jcvenegas good catch!, fixed |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @devimc.
add snapcraft store banner
fixes #1198
Signed-off-by: Julio Montes [email protected]