This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add xurls to versions database #854
Assignees
Comments
jodh-intel
added a commit
to jodh-intel/runtimes
that referenced
this issue
Oct 25, 2018
Add the [`xurls`](https://mvdan.cc/xurls/cmd/xurls) utility to the versions database. This tool is used by the CI scripts in the `tests` repo to check URLs for validity. However, the latest version of `xurls` requires golang 1.10.3+, but we don't need to use the latest version and doing so is causing us problems (see kata-containers/kata-containers#32). Fixes kata-containers#854. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
added a commit
to jodh-intel/runtimes
that referenced
this issue
Oct 25, 2018
Add the [`xurls`](https://mvdan.cc/xurls/cmd/xurls) utility to the versions database. This tool is used by the CI scripts in the `tests` repo to check URLs for validity. However, the latest version of `xurls` requires golang 1.10.3+, but we don't need to use the latest version and doing so is causing us problems (see kata-containers/kata-containers#32). Fixes kata-containers#854. Signed-off-by: James O. D. Hunt <[email protected]>
|
So can we close this？ |
|
I think we can - it is over at https://github.com/kata-containers/tests/blob/master/versions.yaml#L41 and merged already. |
|
Yep - this was fixed on kata-containers/tests#856. |
egernst
pushed a commit
to egernst/runtime
that referenced
this issue
Feb 9, 2021
Currently pciPathToSysfsImpl, which translates PCI paths into sysfs paths accepts only pci paths with exactly 2 components; which represents PCI devices separated from the root bus by exactly one PCI to PCI bridge (which could be a virtual P2P bridge, such as a PCI-E root port). There are cases we might reasonably want to support which have devices either plugged directly into the root bus (zero bridges), or under multiple layers of P2P bridge (a PCI-E switch would require at least 2 layers). So, generalize pciPathToSysfs to support any number of components in the PCI path. We need to adjust some tests to match, not only because of the intended change in behaviour, but also because the new version probes sysfs a bit differently, so we need to mock things to match. fixes kata-containers#854 Signed-off-by: David Gibson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add the
xurlsutility to the versions database to avoid the need to use a very new version of golang (in the stable branches).For a summary of the time we've burnt on fixing xurls, see kata-containers/kata-containers#32.
The text was updated successfully, but these errors were encountered: