Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

factory fails when kernel parameter config is empty #844

Closed
bergwolf opened this issue Oct 19, 2018 · 0 comments
Closed

factory fails when kernel parameter config is empty #844

bergwolf opened this issue Oct 19, 2018 · 0 comments

Comments

@bergwolf
Copy link
Member

When kernel parameter is set to empty, vm factory fails the vm config comparison but look closely the two config values are actually the same.

hypervisor config does not match, base: {HypervisorType:qemu HypervisorConfig:{NumVCPUs:0 DefaultMaxVCPUs:2 MemorySize:0 DefaultBridges:1 Msize9p:81920 MemSlots:10 KernelParams:[] HypervisorParams:[] KernelPath:/usr/share/kata-containers/vmlinuz-4.14.67.11-137.container ImagePath: InitrdPath:/golang/src/github.com/kata-containers/osbuilder/kata-containers-initrd.img FirmwarePath: MachineAccelerators: HypervisorPath:/usr/bin/qemu-lite-system-x86_64 BlockDeviceDriver:virtio-scsi HypervisorMachineType:pc MemoryPath: DevicesStatePath: EntropySource:/dev/urandom customAssets:map[] DisableBlockDeviceUse:false EnableIOThreads:false Debug:true MemPrealloc:false HugePages:false Realtime:false Mlock:false DisableNestingChecks:false UseVSock:false HotplugVFIOOnRootBus:false BootToBeTemplate:false BootFromTemplate:false DisableVhostNet:false} AgentType:kata AgentConfig:{LongLiveConn:false UseVSock:false} ProxyType:noopProxy ProxyConfig:{Path: Debug:false}}. new: {HypervisorType:qemu HypervisorConfig:{NumVCPUs:0 DefaultMaxVCPUs:2 MemorySize:0 DefaultBridges:1 Msize9p:81920 MemSlots:10 KernelParams:[] HypervisorParams:[] KernelPath:/usr/share/kata-containers/vmlinuz-4.14.67.11-137.container ImagePath: InitrdPath:/golang/src/github.com/kata-containers/osbuilder/kata-containers-initrd.img FirmwarePath: MachineAccelerators: HypervisorPath:/usr/bin/qemu-lite-system-x86_64 BlockDeviceDriver:virtio-scsi HypervisorMachineType:pc MemoryPath: DevicesStatePath: EntropySource:/dev/urandom customAssets:map[] DisableBlockDeviceUse:false EnableIOThreads:false Debug:true MemPrealloc:false HugePages:false Realtime:false Mlock:false DisableNestingChecks:false UseVSock:false HotplugVFIOOnRootBus:false BootToBeTemplate:false BootFromTemplate:false DisableVhostNet:false} AgentType:kata AgentConfig:{LongLiveConn:false UseVSock:false} ProxyType:noopProxy ProxyConfig:{Path: Debug:false}}

bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Oct 19, 2018
reflect.DeepEqual would return false when comparing nil map/slice with
empty map/slice. We would want to return success in such case, since it
is possible for upper layers to send these kind of configs.

Fixes: kata-containers#844

Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Oct 19, 2018
reflect.DeepEqual would return false when comparing nil map/slice with
empty map/slice. We would want to return success in such case, since it
is possible for upper layers to send these kind of configs.

Fixes: kata-containers#844

Signed-off-by: Peng Tao <[email protected]>
zklei pushed a commit to zklei/runtime that referenced this issue Nov 22, 2018
reflect.DeepEqual would return false when comparing nil map/slice with
empty map/slice. We would want to return success in such case, since it
is possible for upper layers to send these kind of configs.

Fixes: kata-containers#844

Signed-off-by: Peng Tao <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
…-porting-checks

action: Improve porting checks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant