Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

use qemu x-ignore-shared to implement vm template #1798

Closed
bergwolf opened this issue Jun 14, 2019 · 0 comments
Closed

use qemu x-ignore-shared to implement vm template #1798

bergwolf opened this issue Jun 14, 2019 · 0 comments
Assignees
@bergwolf
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@bergwolf
Copy link
Member

Which feature do you think can be improved?

As we want to move to upstream qemu, we should drop as many private qemu patches as possible. One big change we carry with qemu-lite is the migration bypass-shared-memory patch. Qemu 4.0 already has a x-ignore-shared migration capability. With a small change to it, we can make it work similar to bypass-shared-memory and thus get rid of the private qemu patch.

How can it be improved?

  1. change x-ignore-shared to work similar to bypass-shared-memory. The patch should be easily accepted.
  2. change kata runtime to use x-ignore-shared instead of bypass-shared-memory to implement vm template.
  3. change packaging and tests accordingly.

Additional Information

Depending on whether the little qemu patch is backported to QEMU 4.0, we can either get rid of the private qemu patch soon or the next time we lift the qemu version.
@bergwolf bergwolf added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jun 14, 2019
@bergwolf bergwolf self-assigned this Jun 14, 2019
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Jun 14, 2019
@bergwolf
qemu: use x-ignore-shared to implement vm template
a96e0d8 
qemu upstream has x-ignore-shared that works similar
to our private bypass-shared-memory. We can use it to
implement the vm template feature.

Fixes: kata-containers#1798
Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Jul 17, 2019
@bergwolf
qemu: use x-ignore-shared to implement vm template
7f06cb6 
qemu upstream has x-ignore-shared that works similar
to our private bypass-shared-memory. We can use it to
implement the vm template feature.

Fixes: kata-containers#1798
Depends-on: github.com/kata-containers/packaging#641
Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Jul 17, 2019
@bergwolf
qemu: use x-ignore-shared to implement vm template
3e2f5b6 
qemu upstream has x-ignore-shared that works similar
to our private bypass-shared-memory. We can use it to
implement the vm template feature.

Fixes: kata-containers#1798
Depends-on: github.com/kata-containers/packaging#641
Signed-off-by: Peng Tao <[email protected]>
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Jul 18, 2019
@bergwolf
qemu: use x-ignore-shared to implement vm template
2a92734 
qemu upstream has x-ignore-shared that works similar
to our private bypass-shared-memory. We can use it to
implement the vm template feature.

Fixes: kata-containers#1798
Depends-on: github.com/kata-containers/packaging#641
Signed-off-by: Peng Tao <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Jul 18, 2019
@bergwolf
qemu: use x-ignore-shared to implement vm template
0e873b6 
qemu upstream has x-ignore-shared that works similar
to our private bypass-shared-memory. We can use it to
implement the vm template feature.

Fixes: kata-containers#1798
Depends-on: github.com/kata-containers/packaging#641
Signed-off-by: Peng Tao <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bergwolf bergwolf

Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bergwolf