Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

constification of constifiable vars #142

Closed
egernst opened this issue Apr 2, 2018 · 0 comments
Closed

constification of constifiable vars #142

egernst opened this issue Apr 2, 2018 · 0 comments

Comments

@egernst
Copy link
Member

egernst commented Apr 2, 2018

From @egernst on February 22, 2018 23:22

Noticed that we pretty liberally use var ( ) for what could in many cases be treated as a const.
Example can be seen at https://github.com/containers/virtcontainers/blob/master/kata_agent.go#L38

Some of these are more explicitly marked as var since they are updated during unit tests (see *_test.go) to aid in testing. For the remainder it'd be a good idea to mark these as consts.

Copied from original issue: containers/virtcontainers#636

jiulongzaitian pushed a commit to jiulongzaitian/runtime that referenced this issue Jun 20, 2018
jiulongzaitian pushed a commit to jiulongzaitian/runtime that referenced this issue Jun 20, 2018
jiulongzaitian pushed a commit to jiulongzaitian/runtime that referenced this issue Jun 20, 2018
jiulongzaitian pushed a commit to jiulongzaitian/runtime that referenced this issue Jun 20, 2018
jiulongzaitian pushed a commit to jiulongzaitian/runtime that referenced this issue Jun 20, 2018
jiulongzaitian pushed a commit to jiulongzaitian/runtime that referenced this issue Jun 20, 2018
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant