This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
constification of constifiable vars #142
Comments
This was referenced Apr 2, 2018
jiulongzaitian
pushed a commit
to jiulongzaitian/runtime
that referenced
this issue
Jun 20, 2018
Fixes kata-containers#142 Signed-off-by: zhangjie <[email protected]>
jiulongzaitian
pushed a commit
to jiulongzaitian/runtime
that referenced
this issue
Jun 20, 2018
Fixes kata-containers#142 Signed-off-by: zhangjie <[email protected]>
jiulongzaitian
pushed a commit
to jiulongzaitian/runtime
that referenced
this issue
Jun 20, 2018
Fixes kata-containers#142 Signed-off-by: zhangjie <[email protected]>
jiulongzaitian
pushed a commit
to jiulongzaitian/runtime
that referenced
this issue
Jun 20, 2018
Fixes kata-containers#142 Signed-off-by: zhangjie <[email protected]>
jiulongzaitian
pushed a commit
to jiulongzaitian/runtime
that referenced
this issue
Jun 20, 2018
Fixes kata-containers#142 Signed-off-by: zhangjie <[email protected]>
jiulongzaitian
pushed a commit
to jiulongzaitian/runtime
that referenced
this issue
Jun 20, 2018
Fixes kata-containers#142 Signed-off-by: zhangjie <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From @egernst on February 22, 2018 23:22
Noticed that we pretty liberally use var ( ) for what could in many cases be treated as a const.
Example can be seen at https://github.com/containers/virtcontainers/blob/master/kata_agent.go#L38
Some of these are more explicitly marked as var since they are updated during unit tests (see *_test.go) to aid in testing. For the remainder it'd be a good idea to mark these as consts.
Copied from original issue: containers/virtcontainers#636
The text was updated successfully, but these errors were encountered: