Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Allow build to set default config file path once again #1185

Closed
jodh-intel opened this issue Jan 28, 2019 · 1 comment · Fixed by #1187
Closed

Allow build to set default config file path once again #1185

jodh-intel opened this issue Jan 28, 2019 · 1 comment · Fixed by #1187
Assignees
@devimc
Labels
medium-priority Urgent issue (resolve before unprioritised issues)

Comments

@jodh-intel
Copy link
Contributor

jodh-intel commented Jan 28, 2019 •
edited
Loading

As shown in #1144 (comment), PR #870 inadvertently broke setting the default runtime config file path:

$ make CONFIG_PATH=/foo/bar/configuration.toml
$ ./kata-runtime --kata-show-default-config-paths
/etc/kata-containers/configuration.toml
/usr/share/defaults/kata-containers/configuration.toml

That output is wrong as we'd expect to see /foo/bar/configuration.toml. Here's why:

$ grep -r "var defaultRuntimeConfiguration = "|grep -v CONFIG_PATH 
cli/config-generated.go:var defaultRuntimeConfiguration = "/foo/bar/configuration.toml"
pkg/katautils/config-settings.go:var defaultRuntimeConfiguration = "/usr/share/defaults/kata-containers/configuration.toml"

File cli/config-generated.go, which contains the correct value is not being honoured.
@jodh-intel jodh-intel added the medium-priority Urgent issue (resolve before unprioritised issues) label Jan 28, 2019
@jodh-intel jodh-intel mentioned this issue Jan 28, 2019
Merged
devimc pushed a commit to devimc/kata-runtime that referenced this issue Jan 28, 2019
cli: set config options before showing config paths
68043b5 
Config paths are set correctly but they must be set before handleShowConfig

fixes kata-containers#1185

Signed-off-by: Julio Montes <[email protected]>
@devimc devimc self-assigned this Jan 28, 2019
@devimc devimc mentioned this issue Jan 28, 2019
Merged
devimc pushed a commit to devimc/kata-packaging that referenced this issue Jan 28, 2019
snap: apply patch in runtime to fix config paths
7d77ae9 
This is a hotfix to fix kata-containers/runtime#1185

Signed-off-by: Julio Montes <[email protected]>
@jodh-intel
Copy link
Contributor Author

@devimc - odd, your #1187 PR should have auto-closed this issue but it's still open?

Meh - closing...

egernst pushed a commit to egernst/packaging-1 that referenced this issue Feb 1, 2019
snap: apply patch in runtime to fix config paths
70876b3 
This is a hotfix to fix kata-containers/runtime#1185

Signed-off-by: Julio Montes <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 26, 2019
cli: set config options before showing config paths
6c9325d 
Config paths are set correctly but they must be set before handleShowConfig

fixes kata-containers#1185

Signed-off-by: Julio Montes <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devimc devimc

Labels
medium-priority Urgent issue (resolve before unprioritised issues)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: set config options before showing config paths devimc/kata-runtime
2 participants
@devimc @jodh-intel