logging: Split logging source into two fields

Don't use slash-delimited values in log fields - create two separate log fields (`source` and `subsystem`) for clarity. Signed-off-by: James O. D. Hunt <[email protected]>
kata-containers · Jul 30, 2018 · acdd0b8 · acdd0b8
1 parent c59394d
commit acdd0b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/virtcontainers/pkg/hyperstart/hyperstart.go b/virtcontainers/pkg/hyperstart/hyperstart.go
@@ -124,7 +124,10 @@ var hyperLog = logrus.FieldLogger(logrus.New())
 
 // SetLogger sets the logger for hyperstart package.
 func SetLogger(logger logrus.FieldLogger) {
-	hyperLog = logger.WithField("source", "virtcontainers/hyperstart")
+	hyperLog = logger.WithFields(logrus.Fields{
+		"source":    "virtcontainers",
+		"subsystem": "hyperstart",
+	})
 }
 
 // NewHyperstart returns a new hyperstart structure.

diff --git a/virtcontainers/pkg/oci/utils.go b/virtcontainers/pkg/oci/utils.go
@@ -132,7 +132,10 @@ var ociLog = logrus.FieldLogger(logrus.New())
 
 // SetLogger sets the logger for oci package.
 func SetLogger(logger logrus.FieldLogger) {
-	ociLog = logger.WithField("source", "virtcontainers/oci")
+	ociLog = logger.WithFields(logrus.Fields{
+		"source":    "virtcontainers",
+		"subsystem": "oci",
+	})
 }
 
 func cmdEnvs(spec CompatOCISpec, envs []vc.EnvVar) []vc.EnvVar {