Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Fire a test pr for Arm jenkins test (Do not merge) #97

Closed
wants to merge 1 commit into from

Conversation

kalyxin02
Copy link

Fixes: #57

Signed-off-by: Kaly Xin [email protected]

@jodh-intel
Copy link
Contributor

Hi @kalyxin02 - I've added the do-not-merge label which we use to ensure PRs like this don't land: pullapprove is configured in all our repos to disallow merging when a PR has any of the following tags:

@grahamwhaley
Copy link
Contributor

Just watch out in case the DNM label prevents the CIs from firing.... seeing as this PR is to test the CIs ;-).
I don't think we actually have that configured right now, but - heads up just in case :-)

@grahamwhaley
Copy link
Contributor

Heh heh - hi @kalyxin02 . This PR is not perfectly formed as per our commit rules - but - for now it does not matter I think. What will happen when your slave is working correctly is you should get all the way through the 'setup', and then fail the first check, which is the static checkcommits check. For instance, here is the tail of the log from the 16.04 build:

Drop caches
/tmp/jenkins/workspace/kata-containers-proxy-ubuntu-16-04-PR/go/src/github.com/kata-containers/proxy
make -C cmd/checkcommits
make[1]: Entering directory '/tmp/jenkins/workspace/kata-containers-proxy-ubuntu-16-04-PR/go/src/github.com/kata-containers/tests/cmd/checkcommits'
go test .
ok  	github.com/kata-containers/tests/cmd/checkcommits	0.015s
go install -ldflags "-X main.appCommit="bd52288abf9d51dba9862cfe2cd083222810d6cd" -X main.appVersion=0.0.1" .
make[1]: Leaving directory '/tmp/jenkins/workspace/kata-containers-proxy-ubuntu-16-04-PR/go/src/github.com/kata-containers/tests/cmd/checkcommits'
Running checkcommits version 0.0.1 (commit bd52288abf9d51dba9862cfe2cd083222810d6cd)
Defaulting commit to HEAD
Defaulting branch to master
Found 1 commit between commit HEAD and branch master
ERROR: Commit 6f513e6ce4d7eea2a8b1671235803e54962b940a: Failed to find subsystem in subject: "Fire a test pr for Arm jenkins test"
ERROR: checkcommits failed. See the document below for help on formatting
commits for the project.

https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format

Build step 'Execute shell' marked build as failure

If/when you get to that stage, then fix the PR to match the checkcommits requirements, and see what the next failure (or success!) is :-)

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 3, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@chavafg
Copy link
Contributor

chavafg commented Aug 3, 2018

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 8, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 10, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #97 into master will increase coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   37.26%   38.02%   +0.76%     
==========================================
  Files           2        2              
  Lines         263      263              
==========================================
+ Hits           98      100       +2     
+ Misses        154      153       -1     
+ Partials       11       10       -1

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 23, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@kalyxin02 kalyxin02 force-pushed the test-pr branch 2 times, most recently from 55cc9c3 to ed125ae Compare August 24, 2018 06:55
@opendev-zuul
Copy link

opendev-zuul bot commented Aug 24, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@kalyxin02
Copy link
Author

Hi, @grahamwhaley, at last we got a success build at http://jenkins.katacontainers.io/job/kata-containers-proxy-ARM-18.04-PR/33/console after we made some cleanup work to restore the environment especially when the previous build failed. @Pennyzct will send the patches to upstream soon. :-)

Thanks
Kaly

@grahamwhaley
Copy link
Contributor

Woot! 🎆

Yeah, clean environment is a problem if you cannot run in a VM or clean bare-metal for each build (kata-containers/ci#39) - I will look out for your patches - worst case I think you will have to completely clean and restart docker (including /var/lib/docker), and possibly some kata bits (/var/lib/vc sbs etc.). 95% of PR builds are fine, but every now and then a PR will knock things crazy.

@grahamwhaley
Copy link
Contributor

/cc @ydjainopensource , who may be interested in those patches for IBM Z Jenkins kata setup as well...

@ghost
Copy link

ghost commented Aug 24, 2018

@Pennyzct @grahamwhaley Yes, the patches will help prevent rework.

@opendev-zuul
Copy link

opendev-zuul bot commented Aug 31, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

Fire a test pr for Arm jenkins test kata-containers#7

Fixes kata-containers#57

Signed-off-by: kaly xin <[email protected]>
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 5, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@grahamwhaley
Copy link
Contributor

Speaking of which, how is the ARM CI status @kalyxin02 ? I see we had some passes, and then some fails - wondering what there is left here to do, and what it will take to get to enable the ARM CI across more repos? :-)

@jodh-intel
Copy link
Contributor

Ping @kalyxin02 and @Pennyzct - could you give us an update on the ARM64 CI status? 😄

@grahamwhaley
Copy link
Contributor

heh heh - I actually want to re-run a metrics build, so will piggy back here and try a:
/test
and, we have discussed having a metrics specific trigger phrase - one that will trigger metrics only. Just, we are not there yet.

@kalyxin02
Copy link
Author

Hi, @grahamwhaley @jodh-intel, sorry for the late response. Seems we do have some problems on current CI testing. Sigh... Let us figure it out first.

@jodh-intel
Copy link
Contributor

Hi @kalyxin02 - no problem. Let us know if we can help in any way.

@caoruidong
Copy link
Member

Does it work now?

@raravena80
Copy link
Member

@kalyxin02 ping (from your weekly Kata herder)

@jodh-intel
Copy link
Contributor

Hi @kalyxin02 - any update on this?

@kalyxin02
Copy link
Author

@jodh-intel It works. Now we identified some features missing on the platform, and some of the changes may need to upgrade the current kernel, for example, to support persistent memory. @Pennyzct is currently verifying the test cases. After that we would request to upgrade to 4.20 or even newer kernel. Will this cause any problem for the testing environment, for example, to generate new test jobs from the server side?

Thanks
Kaly

@jodh-intel
Copy link
Contributor

Hi @kalyxin02 - great. Regarding the kernel, our strategy is to use the "newest longterm" kernel so, yes, as of today, using 4.20 would deviate from that approach. See:

However, as you know we have separate config files for each architecture so in theory you could update the arm config to 4.20:

However, we'd then have potentially different behaviour depending on architecture which doesn't sound ideal.

Maybe it would be worth adding this as a topic for the Architecture Committee meeting.

/cc @egernst, @grahamwhaley, @chavafg.

@raravena80
Copy link
Member

@kalyxin02 any updates is ARM Jenkins complete?

@jodh-intel
Copy link
Contributor

It looks like the Jenkins CI is working for ARM64 now so can this be closed?

@grahamwhaley
Copy link
Contributor

hijacking this test PR to fire an IBM Power8 build as well ;-)
/test

@nitkon
Copy link
Contributor

nitkon commented Jan 15, 2019

/test

@nitkon
Copy link
Contributor

nitkon commented Jan 18, 2019

/retest

1 similar comment
@nitkon
Copy link
Contributor

nitkon commented Jan 25, 2019

/retest

@nitkon
Copy link
Contributor

nitkon commented Jan 27, 2019

@kalyxin02 : Could you please rebase/close this PR. I have raised another PR to address this issue till then.

@kalyxin02 kalyxin02 closed this Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants