This repository has been archived by the owner on May 12, 2021. It is now read-only.
main: stacktrace/coredump on error #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #60. See also: kata-containers/shim#59. |
|
static check fail on Travis |
grahamwhaley
approved these changes
Mar 8, 2018
jodh-intel
force-pushed
the
stacktrace-on-error
branch
from
2bb9763
to
203aac5
Compare
|
Branch updated. |
If the proxy fails due to an internal error or if it receives a fatal signal, write a stack trace to the log and exit. If it was started with `--debug` also dump core. Note: `handleVersion()` introduced to keep `gocyclo` happy. Fixes kata-containers#59. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
stacktrace-on-error
branch
from
203aac5
to
33b4a1d
Compare
|
Travis is now happy. |
This was referenced Mar 9, 2018
|
ping @kata-containers/proxy. |
|
LGTM |
|
Wow, I'd forgotten about this one. CAn we get one more ack before we consider force-merging? :) |
|
2 weeks is a long time on this project ;) |
|
Please can we get some eyeballs on this? This PR has been open for 18 days now. It's non-contentious and is very similar in content to the following already-merged PRs: |
|
LGTM ‘casue it's a similar PR. @WeiZhang555 Can you help @jodh-intel get review +1 |
|
I think you can reping members... |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the proxy fails due to an internal error or if it receives
a fatal signal, write a stack trace to the log and exit.
If it was started with
--debugalso dump core.Fixes #59.
Signed-off-by: James O. D. Hunt [email protected]