mount: Fix hugepages support

[bpradipt]

Fixes: #871

Signed-off-by: Pradipta Banerjee [email protected]

[egernst]

This part seems more straight forward... though I see one issue (need to return error). The hard part is making sure "these" huge pages are backed by "actual" huge pages from the host.

[bpradipt]

/test-ubuntu

[bpradipt]

/test-vfio

[bpradipt]

/test-ubuntu

[bpradipt]

/test-vfio

[bpradipt]

/test-vfio

[bpradipt]

The vfio test failure is unrelated and looks like this is the cause /usr/bin/cloud-hypervisor does not exist .

@dgibson @jodh-intel can you please take a look at this PR. I have incorporated all the changes. Post your review I can start working on forward porting the hugepages changes to 2.x. Thanks

[egernst]

I have some questions still, from kata-containers/runtime#2353 (comment)

I’m okay with adding support, but I think it should be behind a feature gate, since I think this may cause issues in Kube (our memory overhead will consume a lot of the pages).

[dgibson]

LGTM

[jodh-intel]

Thanks @bpradipt.

lgtm

[bpradipt]

I have some questions still, from kata-containers/runtime#2353 (comment)

I’m okay with adding support, but I think it should be behind a feature gate, since I think this may cause issues in Kube (our memory overhead will consume a lot of the pages).

Sorry @egernst, I completely missed it. I have posted few questions and let's discuss to arrive at a consensus.

[fidencio]

/test-vfio

[bpradipt]

/test-vfio

[devimc]

hold on please, the CI didn't run

[devimc]

I'm investigating the issue

INFO: No forcing label found
Short circuit fast path skipping the rest of the CI.

[devimc]

@bpradipt - I see you want to merge this in master

bpradipt wants to merge 1 commit into kata-containers:master

is that correct?

[bpradipt]

@bpradipt - I see you want to merge this in master

bpradipt wants to merge 1 commit into kata-containers:master

is that correct?

This is for kata-containers/agent master (1.x)

[devimc]

CI is buggy, no changes were detected 😞

+ info 'Checking for any changed files that will prevent CI fastpath return'
+ echo -e 'INFO: Checking for any changed files that will prevent CI fastpath return'
INFO: Checking for any changed files that will prevent CI fastpath return
++ can_we_skip
++ '[' '' = true ']'
+++ get_pr_changed_file_details_full
+++ local filters=
+++ filters+=A
+++ filters+=C
+++ filters+=M
+++ filters+=R
+++ filters+=UX
+++ git diff-tree -r --name-status --diff-filter=ACMRUX origin/master HEAD
++ filenames=
+++ echo ''
+++ awk '{print $NF}'
++ filenames=
++ '[' -z '' ']'
++ local_info 'No files found'
++ msg='No files found'
++ info 'No files found'
++ echo -e 'INFO: No files found'
INFO: No files found

[devimc]

/test-ubuntu
/test-vfio

[fidencio]

/test-ubuntu

[fidencio]

On a side note, I decided to take a look at the jenkins-ci-ubuntu-18-04 and it's building the rust agent. Why? Oo