This repository has been archived by the owner on May 12, 2021. It is now read-only.
action: Improve porting checks #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the PR porting GitHub action by referencing a central script to handle the checks rather than hard-coding them in the workflow YAML. This ensures all PRs use the latest porting policy encoded in the script and makes maintenance easier. Related: kata-containers/kata-containers#634 Fixes: kata-containers#843. Signed-off-by: James O. D. Hunt <[email protected]>
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 60.08% 60.15% +0.07%
==========================================
Files 17 17
Lines 2668 2668
==========================================
+ Hits 1603 1605 +2
+ Misses 902 901 -1
+ Partials 163 162 -1 |
|
/test-ubuntu |
jodh-intel
added
no-backport-needed
|
/test |
|
Ping @kata-containers/agent - a very quick PR to review and hopefully ack so we can get the last of these PRs landed... |
|
This PR needs 1 more ack... today would be great folks! |
devimc
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the PR porting GitHub action by referencing a central script to
handle the checks rather than hard-coding them in the workflow YAML.
This ensures all PRs use the latest porting policy encoded in the
script and makes maintenance easier.
Related: kata-containers/kata-containers#634
Fixes: #843.
Signed-off-by: James O. D. Hunt [email protected]