This repository has been archived by the owner on May 12, 2021. It is now read-only.
revert: agent: sandbox_pause should get arguments from proc #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
When agent runs as init, it is not able to read `/proc/self/cmdline` because of `/proc` has not been mounted when the C constructor is called. This reverts commit cfbd8c9. fixes kata-containers#620 Signed-off-by: Julio Montes <[email protected]>
devimc
force-pushed
the
topic/agent/revert585
branch
from
346bc66
to
72a50ef
Compare
|
/test |
chavafg
approved these changes
Aug 1, 2019
GabyCT
approved these changes
Aug 1, 2019
|
Lets wait for @bergwolf 's input before this is merged. |
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 61.14% 61.22% +0.08%
==========================================
Files 17 17
Lines 2486 2486
==========================================
+ Hits 1520 1522 +2
+ Misses 820 819 -1
+ Partials 146 145 -1 |
|
Looks ready to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When agent runs as init, it is not able to read
/proc/self/cmdlinebecauseof
/prochas not been mounted when the C constructor is called.This reverts commit cfbd8c9.
fixes #620
Signed-off-by: Julio Montes [email protected]