-
Notifications
You must be signed in to change notification settings - Fork 113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
one query
documentation/features/cpuset.md
Outdated
|
||
This should result with the container limited to the time of 2 CPUs, but is | ||
only allowed to be scheduled on CPUs 0 and 1. | ||
|
||
The following is an example of a similar case with a valid traditional container: | ||
|
||
docker run -ti --cpus 2 --cpuset 2,3,4 busybox | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no sh
or bash
type on the formatting? Maybe on purpose to skip auto processing (in which case I think I normally make them sh
, as only bash
gets auto processed...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - updated for sh
.
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
=======================================
Coverage 50.48% 50.48%
=======================================
Files 17 17
Lines 2385 2385
=======================================
Hits 1204 1204
Misses 1025 1025
Partials 156 156 |
Fix spelling mistakes and formatting issues. Fixes kata-containers#562. Signed-off-by: James O. D. Hunt <[email protected]>
/test |
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
=======================================
Coverage 50.48% 50.48%
=======================================
Files 17 17
Lines 2385 2385
=======================================
Hits 1204 1204
Misses 1025 1025
Partials 156 156 |
2 CI's are failing but this is a doc-only PR, so merging... |
Fix spelling mistakes and formatting issues.
Fixes #562.
Signed-off-by: James O. D. Hunt [email protected]