Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

docs: Fix typos and formatting #563

Merged
merged 1 commit into from
May 29, 2019

Conversation

jodh-intel
Copy link
Contributor

Fix spelling mistakes and formatting issues.

Fixes #562.

Signed-off-by: James O. D. Hunt [email protected]

Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
one query


This should result with the container limited to the time of 2 CPUs, but is
only allowed to be scheduled on CPUs 0 and 1.

The following is an example of a similar case with a valid traditional container:

docker run -ti --cpus 2 --cpuset 2,3,4 busybox
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no sh or bash type on the formatting? Maybe on purpose to skip auto processing (in which case I think I normally make them sh, as only bash gets auto processed...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - updated for sh.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #563 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   50.48%   50.48%           
=======================================
  Files          17       17           
  Lines        2385     2385           
=======================================
  Hits         1204     1204           
  Misses       1025     1025           
  Partials      156      156

Fix spelling mistakes and formatting issues.

Fixes kata-containers#562.

Signed-off-by: James O. D. Hunt <[email protected]>
@jodh-intel
Copy link
Contributor Author

/test

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #563 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   50.48%   50.48%           
=======================================
  Files          17       17           
  Lines        2385     2385           
=======================================
  Hits         1204     1204           
  Misses       1025     1025           
  Partials      156      156

@jodh-intel
Copy link
Contributor Author

2 CI's are failing but this is a doc-only PR, so merging...

@jodh-intel jodh-intel merged commit eba24ce into kata-containers:master May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docs
3 participants