Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

client: do cleanup after UT stop mock server #419

Merged
merged 1 commit into from
Dec 7, 2018
Merged

client: do cleanup after UT stop mock server #419

merged 1 commit into from
Dec 7, 2018

Conversation

BetaXOi
Copy link

@BetaXOi BetaXOi commented Nov 29, 2018

Remove /tmp/agentserver.socker when test case is done and output firendly error message when remove the file failed.

Fixes #418

Signed-off-by: NingBo [email protected]

@jodh-intel
Copy link
Contributor

jodh-intel commented Nov 29, 2018 •
edited by amshinde
Loading

Good catch! And we like friendly messages 😄

lgtm

/test

Approved with PullApprove

grahamwhaley
grahamwhaley approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - nice to see such improvements.
lgtm

client: do cleanup after UT stop mock server
4eca13b 
Remove /tmp/agentserver.socker when test case is done and output
firendly error message when remove the file failed.

Fixes kata-containers#418

Signed-off-by: NingBo <[email protected]>
@jodh-intel
Copy link
Contributor

Thanks @BetaXOi!

lgtm

/test

devimc
devimc approved these changes Nov 29, 2018
View reviewed changes
Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link
Contributor

Re-started the 16.04 CI which got wedged on what looks like an external net connectivity issue:

not ok 1 Verify nginx connectivity between pods
# (from function `setup' in test file nginx.bats, line 19)
#   `sudo -E crictl pull "$nginx_image"' failed
# Image is up to date for docker.io/library/busybox@sha256:915f390a8912e16d4beb8689720a17348f3f6d1a7b659697df850ab625ea29d5
# time="2018-11-30T02:38:08Z" level=fatal msg="pulling image failed: rpc error: code = Unknown desc = Error writing blob: error storing blob to file \"/var/tmp/storage826968591/2\": read tcp 10.0.0.9:47454->104.18.125.25:443: read: connection reset by peer"
# Error from server (NotFound): deployments.extensions "nginx-deployment" not found
# Error from server (NotFound): services "nginx-deployment" not found
# error: resource name may not be empty
Makefile:69: recipe for target 'kubernetes' failed

@bergwolf
Copy link
Member

bergwolf commented Dec 7, 2018 •
edited by amshinde
Loading

lgtm, thanks @BetaXOi !

Approved with PullApprove

@bergwolf bergwolf merged commit e7633c7 into kata-containers:master Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jodh-intel jodh-intel jodh-intel left review comments

@jcvenegas jcvenegas jcvenegas approved these changes

@devimc devimc devimc approved these changes

@grahamwhaley grahamwhaley grahamwhaley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BetaXOi @jodh-intel @bergwolf @grahamwhaley @devimc @jcvenegas