This repository has been archived by the owner on May 12, 2021. It is now read-only.
agent: Fix the issue of stdout hang on builtin proxy #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Yamux's keepalive has been disabled both on the server and the client side, and this brings a weird issue where the communication between the proxy and the agent hangs. The same issue has been fixed in kata proxy by: "kata-containers/proxy#91". This commit just cherry-pick that patch here to fix the same issue on kata builtin proxy. Fixes: kata-containers#396 Signed-off-by: fupan <[email protected]>
|
lgtm |
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
+ Coverage 47.83% 47.96% +0.12%
==========================================
Files 17 17
Lines 2638 2648 +10
==========================================
+ Hits 1262 1270 +8
- Misses 1215 1216 +1
- Partials 161 162 +1 |
sboeuf
approved these changes
Oct 15, 2018
|
/test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Yamux's keepalive has been disabled both
on the server and the client side, and this brings
a weird issue where the communication between the
proxy and the agent hangs. The same issue has been
fixed in kata proxy by:
"kata-containers/proxy#91".
This commit just cherry-pick that patch here to
fix the same issue on kata builtin proxy.
Fixes: #396
Signed-off-by: fupan [email protected]