Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

updateInterface: fail to hot-add nic to container on arm64 #544

Closed
jongwu opened this issue Apr 30, 2019 · 0 comments · Fixed by #545
Closed

updateInterface: fail to hot-add nic to container on arm64 #544

jongwu opened this issue Apr 30, 2019 · 0 comments · Fixed by #545

Comments

@jongwu
Copy link
Contributor

jongwu commented Apr 30, 2019

Description of problem

when hot-add nic to a kata-container on arm64, updateInterface will report error of time out to wait for nic device

Expected result

(replace this text with an explanation of what you thought would happen)

Actual result

(replace this text with details of what actually happened)


(replace this text with the output of the kata-collect-data.sh script, after
you have reviewed its content to ensure it does not contain any private
information).

jongwu added a commit to jongwu/agent that referenced this issue Apr 30, 2019
For now, update interface in agent will fail when hot-add
nic to a running containers on arm64 as rescan pci bus will
occur between up hf and bf of shpc hotplug interrupt handling.

Another problem is that as pcie bridge is used when create vm
for arm64, the rootBusPath will be
"/devices/platform/4010000000.pcie/pci0000:00".

This patch remove the implementation of rescan and change the
rootBusPath for arm64.

Fixes: kata-containers#544
Signed-off-by: Jianyong Wu <[email protected]>
jongwu added a commit to jongwu/agent that referenced this issue Apr 30, 2019
For now, update interface in agent will fail when hot-add
nic to a running containers on arm64 as rescan pci bus will
occur between up hf and bf of shpc hotplug interrupt handling.

Another problem is that as pcie bridge is used when create vm
for arm64, the rootBusPath will be
"/devices/platform/4010000000.pcie/pci0000:00".

This patch remove the implementation of rescan and change the
rootBusPath for arm64.

Fixes: kata-containers#544
Signed-off-by: Jianyong Wu <[email protected]>
jongwu added a commit to jongwu/agent that referenced this issue Apr 30, 2019
For now, update interface in agent will fail when hot-add
nic to a running containers on arm64 as rescan pci bus will
occur between up hf and bf of shpc hotplug interrupt handling.

Another problem is that as pcie bridge is used when create vm
for arm64, the rootBusPath will be
"/devices/platform/4010000000.pcie/pci0000:00".

This patch remove the implementation of rescan and change the
rootBusPath for arm64.

Fixes: kata-containers#544
Signed-off-by: Jianyong Wu <[email protected]>
jongwu added a commit to jongwu/agent that referenced this issue May 7, 2019
For now, update interface in agent will fail when hot-add
nic to a running containers on arm64 as rescan pci bus will
occur between uf and bf of shpc hotplug interrupt handling.

Another problem is that the rootBusPath will be
"/devices/platform/4010000000.pcie/pci0000:00" on arm64.

To enable hot-add nic on arm64, rootBusPath should be changed here
and shpc hotplug should be disabled in guest kernel.

This patch just change rootBusPath.

Fixes: kata-containers#544
Signed-off-by: Jianyong Wu <[email protected]>
jongwu added a commit to jongwu/agent that referenced this issue May 15, 2019
For now, update interface in agent will fail when hot-add
nic to a running containers on arm64 as rescan pci bus will
occur between uf and bf of shpc hotplug interrupt handling.

Another problem is that the rootBusPath will be
"/devices/platform/4010000000.pcie/pci0000:00" on arm64.

To enable hot-add nic on arm64, rootBusPath should be changed here
and shpc hotplug should be disabled in guest kernel.

This patch just change rootBusPath.

Fixes: kata-containers#544
Signed-off-by: Jianyong Wu <[email protected]>
jongwu added a commit to jongwu/agent that referenced this issue May 15, 2019
For now, update interface in agent will fail when hot-add
nic to a running containers on arm64 as rescan pci bus will
occur between uf and bf of shpc hotplug interrupt handling.

Another problem is that the rootBusPath will be
"/devices/platform/4010000000.pcie/pci0000:00" on arm64.

To enable hot-add nic on arm64, rootBusPath should be changed here
and shpc hotplug should be disabled in guest kernel.

This patch just change rootBusPath.

Fixes: kata-containers#544
Signed-off-by: Jianyong Wu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant