Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment checker #13

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

mamaz
Copy link

@mamaz mamaz commented Dec 27, 2018

Overview

Often times when we want to run a Merapi service, some env variables are not set yet, even though it is needed, it will decrease developer experience since we don't know how many env variables needed to be set correctly in order to run service correctly according to configuration.

How to solve

  • Add environment validator to check whether all the env, has already been set.
  • It will also tell list of environments that needs to be added beforehand.

How to test

  • Run unit test

Copy link
Contributor

@reyhansofian reyhansofian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mamaz
Copy link
Author

mamaz commented Dec 27, 2018

OK

@mamaz
Copy link
Author

mamaz commented Jan 3, 2019

Updated :)

Kindly review again.

@mamaz mamaz requested a review from mandocaesar January 7, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants