Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep_term_open also keeps hidden terminals open #238

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

mrichards42
Copy link
Contributor

Thanks for a great plugin!

This PR uses the value of g:neoterm_keep_term_open to prevent hidden terminal buffers from being closed. I often switch between files and terminal buffers, and without this my terminal buffers keep getting deleted.

Happy to consider a different config option if you're OK with the idea but don't want to overload keep_term_open.

@kassio
Copy link
Owner

kassio commented Jun 7, 2019

Can you add a changelog on the readme, please?

@mrichards42
Copy link
Contributor Author

Absolutely -- done

Copy link
Collaborator

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This option needs to be added in the docs

4. Options *neoterm-vars* *neoterm-variables* *neoterm-options*

And a default value should be given around these lines

if !exists('g:neoterm_size')

@stsewd
Copy link
Collaborator

stsewd commented Jun 7, 2019

Oops, I thought this was a new option, but we should still put the new behavior in the docs :)

@kassio
Copy link
Owner

kassio commented Jun 10, 2019

Yeah, agreed. Can you add the behavior on the g:neoterm_keep_term_open docs, please?

@mrichards42
Copy link
Contributor Author

Added to the docs -- see if that phrasing makes sense to you.

@kassio kassio merged commit 86eaa75 into kassio:master Jun 21, 2019
@mrichards42 mrichards42 deleted the set-bufhidden branch June 21, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants