Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topen resizes vertically as well on vertical splits #239

Closed
frm opened this issue Jun 17, 2019 · 1 comment · Fixed by #240
Closed

Topen resizes vertically as well on vertical splits #239

frm opened this issue Jun 17, 2019 · 1 comment · Fixed by #240
Labels

Comments

@frm
Copy link
Contributor

frm commented Jun 17, 2019

You can see the problem here:

asciicast

I try to have a vertical split, but it resizes neovim vertically as well. It's been like this for a while now.

My configs to reproduce:

let g:neoterm_shell = "zsh"
let g:neoterm_default_mod="vertical"
let g:neoterm_size=40

I also tried adding the following, which didn't fix it:

let g:neoterm_fixedsize=40
let g:neoterm_autoscroll=1
let g:neoterm_autojump=1

If I set g:neoterm_size to 70 it doesn't happen anymore.

@kassio kassio added the bug label Jun 17, 2019
@frm
Copy link
Contributor Author

frm commented Jun 17, 2019

I was able to determine that this was introduced in 3974cf6.

Calling resize is assuming the mod is empty (or set to a horizontal split). Calling exec(l:mod . ' resize ' . g:neoterm_size) fixes it. I'll be opening a PR with that change.

frm added a commit to frm/neoterm that referenced this issue Jun 17, 2019
frm added a commit to frm/neoterm that referenced this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants