This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
api: pull_requests: add pagination #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(murdock needed a restart since the opening of this PR so the loading times aren't that large anymore ;-)) |
This adds [Github-like pagination][1] to the `/api/pull_requests` API call. The following rules are applied: - Pages start counting at 1. - A page can be selected via the `page` query argument, the number of entries can be set via the `per_page` query argument. - The ["Link" HTTP-header][2] provide links to appropriate pages to navigate to (`next`, `last`, `first`, `prev`) - Building and queued jobs (collectively called *"pending jobs"* in the following) are always on the first page. - If the number pending jobs is lesser than `per_page`, a subset of the finished jobs is shown. Their number is determined by the difference between `per_page` and the number of pending jobs. - If the number of pending jobs is greater than or equal to `per_page`, finished jobs start on the second page. [1]: https://developer.github.com/v3/#pagination [2]: https://tools.ietf.org/html/rfc8288
miri64
force-pushed
the
pull_requests-pagination
branch
from
6f12190
to
3b9b912
Compare
|
This became an issue again so I rebased. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Github-like pagination to the
/api/pull_requestsAPIcall.
The following rules are applied:
pagequery argument, the number ofentries can be set via the
per_pagequery argument.navigate to (
next,last,first,prev)following) are always on the first page.
per_page, a subset of thefinished jobs is shown. Their number is determined by the difference
between
per_pageand the number of pending jobs.per_page,finished jobs start on the second page.
Fixes #18