Add styles to qgs file #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the end result will be similar to the abandon kartoza#472 fix kartoza#406 fix kartoza#325
|
@lucernae the unittest will come later as i'm still struggling to make it passed |
Codecov Report
@@ Coverage Diff @@
## 2.8.x-qgis_server #474 +/- ##
=====================================================
+ Coverage 41.36% 41.37% +0.01%
=====================================================
Files 403 403
Lines 28950 28968 +18
Branches 3671 3678 +7
=====================================================
+ Hits 11974 11986 +12
- Misses 16234 16236 +2
- Partials 742 746 +4
Continue to review full report at Codecov.
|
|
merge and deploy asap @boney-bun so we can test |
lucernae
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
LGTM. Thanks!
@boney-bun please add docstring for the new parameter.
Also, create a unittest for this in a separate PR.
|
thanks @lucernae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the end result will be similar to the abandon #472
fix #406
fix #325