Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an embed widget link #153

Closed
gubuntu opened this issue Mar 15, 2017 · 12 comments · Fixed by #314 or #343
Closed

Create an embed widget link #153

gubuntu opened this issue Mar 15, 2017 · 12 comments · Fixed by #314 or #343
Assignees
Milestone

Comments

@gubuntu
Copy link

gubuntu commented Mar 15, 2017

Link that gives you an embed widget for embedding a map in your own site. This is another variant of the above approaches, but this time will return an embeddable widget as html and JavaScript snippets that can be incorporated into an existing web site. Implemented for QGIS backend only.

child of #457

@gubuntu gubuntu added this to the Sprint 2 milestone Mar 15, 2017
@gubuntu gubuntu added the ready label Aug 10, 2017
boney-bun added a commit to boney-bun/geonode that referenced this issue Aug 21, 2017
boney-bun added a commit to boney-bun/geonode that referenced this issue Sep 19, 2017
boney-bun added a commit that referenced this issue Sep 19, 2017
@timlinux
Copy link

Please test, this does not work for me - see #336

@gubuntu
Copy link
Author

gubuntu commented Oct 20, 2017

broken
Screen Shot 2017-10-20 at 18.23.58.png

@boney-bun
Copy link

#376 should fix the bug on firefox

@boney-bun
Copy link

it's fixed on the testing.
could we close this issue?

@gubuntu
Copy link
Author

gubuntu commented Feb 9, 2018

The embed map code does get generated. But please actually test it by embedding it in a page and confirming that it works before we close this.

@NyakudyaA
Copy link
Collaborator

NyakudyaA commented Feb 15, 2018

@boney-bun Tested this and it's still not rendering the actual layers when you use embed-iframe-link. The extent is correct but the layer is not rendering:
screenshot from 2018-02-15 11-39-01

But it is also working when using embed widget link

@NyakudyaA
Copy link
Collaborator

@boney-bun Could we also have the same icon layout for the widget links.
This one has an option for a user to copy the code.
embed_widget_link

Add the copy code link as well:
embed_iframe_link

@gubuntu gubuntu added the bug label Feb 15, 2018
@boney-bun
Copy link

from #394:

Steps on create an embed widget link

clicks embed map on a map.
Then choose embed iframe link.
copy the snippet on a text editor, save as a html file.
loads the html file in the browser.
the result is all layers will be rendered instead, not specifically for the chosen map.

Expected Result

The html file should show only the layers within the map, not all layers.

@boney-bun
Copy link

@boney-bun Could we also have the same icon layout for the widget links.

@NyakudyaA #410 addresses your sugggestion.

@gubuntu
Copy link
Author

gubuntu commented Jul 20, 2018

@boney-bun please post a screencast to show an embed widget working before we can close this.

@boney-bun
Copy link

@gubuntu here are the screencast:
using firefox:
geonode 153_2

using chrome:
geonode 153

@NyakudyaA
Copy link
Collaborator

TEsted widget link in Chrome,Firefox and opera mini and it all works. I will close this and open another issue that relates to the embeded iframe link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment