Fix for title option #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A variable is considered empty if it does not exist or if its value equals FALSE. Therefore, setting the title option to false was not having the desired effect of removing the title from the append/prepend components. Changed function to isset that determines if a variable is set and is not NULL. To summarize: empty(false) return true but !isset(false) returns false.
| @@ -222,7 +222,7 @@ protected function renderAddon(&$options, $type = 'picker') | |||
| $icon = ($type === 'picker') ? 'calendar' : 'remove'; | |||
| Html::addCssClass($options, 'input-group-addon kv-date-' . $icon); | |||
| $icon = '<i class="glyphicon glyphicon-' . ArrayHelper::remove($options, 'icon', $icon) . '"></i>'; | |||
| if (empty($options['title'])) { | |||
| if (!isset($options['title'])) { | |||
| $title = ($type === 'picker') ? Yii::t('kvdate', 'Select date') : Yii::t('kvdate', 'Clear field'); | |||
| if ($title != false) { | |||
There was a problem hiding this comment.
This condition will never get executed. $title is always set to a valid string before.
|
I will provide a fix for this via this PR. |
|
Resolved via 5771894. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variable is considered empty if it does not exist or if its value equals FALSE. Therefore, setting the title option to false was not having the desired effect of removing the title from the append/prepend components. Changed function to isset that determines if a variable is set and is not NULL. To summarize: empty(false) return true but !isset(false) returns false.