Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Processing" when waiting for server response #729

Closed
workgena opened this issue Aug 1, 2016 · 3 comments
Closed

Show "Processing" when waiting for server response #729

workgena opened this issue Aug 1, 2016 · 3 comments

Comments

@workgena
Copy link

workgena commented Aug 1, 2016

Uploading progress bar shows only number of bytes transferred to server.

But in some cases server do manipulations with file, and it also takes some time. Meanwhile upload progress shows 100%. It is confusing for user experience.

I propose not to show 100%-progress until file completely processed by server.

link to draft implementation

In this implementation, I use "Freeze Threshold" == 95%. When uploading reaches this threshold, progress bar freezes and shows "Processing" message. If file completely processed by server, it will show 100%.

kartik-v added a commit that referenced this issue Aug 2, 2016
@workgena
Copy link
Author

workgena commented Aug 2, 2016

Thanks for quick response! But the new implementation has some errors(see comments)

@workgena
Copy link
Author

workgena commented Aug 2, 2016

Second commit(with "101" magic number 😕) almost works.

Replacement is a bit wrong, fix:

$el.html( template.replace('{percent}', pctLimit).replace('{percent}', pctLimit).replace('{percent}%', self.msgUploadThreshold) );

kartik-v added a commit that referenced this issue Aug 2, 2016
@workgena
Copy link
Author

workgena commented Aug 2, 2016

Thx, checked last commit in my current project. All works. But, I checked only one file upload at once, not in batch.

kartik-v added a commit that referenced this issue Aug 2, 2016
kartik-v added a commit that referenced this issue Aug 2, 2016
kartik-v added a commit that referenced this issue Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants