fix: estimate_mfu dt ZeroDivisionError #446
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous estimate_mfu function has ZeroDivisionError error
In model.py 301 line,
flops_achieved = flops_per_iter * (1.0/dt)
will occur ZeroDivisionError, which meansdt
will be Zero when the time interval between two consecutive calls to time.time() is so small that it is considered as 0 under floating point precision.replicate the problem
I am training on my single 4090 card, and every time I start the training code it will occur ZeroDivisionError.