Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add work queue metrics for agent and controller-manager #831

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

Garrybest
Copy link
Member

@Garrybest Garrybest commented Oct 19, 2021

Signed-off-by: Garrybest [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:
The async worker queue metrics will be registered here. So we should init the package first.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Instrumentation: Introduced several metrics(`workqueue_adds_total`, `workqueue_depth`, `workqueue_longest_running_processor_seconds`, `workqueue_queue_duration_seconds_bucket`) for `karmada-agent` and `karmada-controller-manager`.

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2021
@RainbowMango
Copy link
Member

LGTM.
What's the metrics look like?

@Garrybest
Copy link
Member Author

# HELP workqueue_adds_total Total number of adds handled by workqueue
# TYPE workqueue_adds_total counter
workqueue_adds_total{name="cluster"} 22547
workqueue_adds_total{name="service-export"} 0
workqueue_adds_total{name="work"} 314072
workqueue_adds_total{name="work-status"} 527134
# HELP workqueue_depth Current depth of workqueue
# TYPE workqueue_depth gauge
workqueue_depth{name="cluster"} 0
workqueue_depth{name="service-export"} 0
workqueue_depth{name="work"} 0
workqueue_depth{name="work-status"} 0
# HELP workqueue_longest_running_processor_seconds How many seconds has the longest running processor for workqueue been running.
# TYPE workqueue_longest_running_processor_seconds gauge
workqueue_longest_running_processor_seconds{name="cluster"} 0
workqueue_longest_running_processor_seconds{name="service-export"} 0
workqueue_longest_running_processor_seconds{name="work"} 0
workqueue_longest_running_processor_seconds{name="work-status"} 0
# HELP workqueue_queue_duration_seconds How long in seconds an item stays in workqueue before being requested
# TYPE workqueue_queue_duration_seconds histogram
workqueue_queue_duration_seconds_bucket{name="cluster",le="1e-08"} 0
workqueue_queue_duration_seconds_bucket{name="cluster",le="1e-07"} 0
workqueue_queue_duration_seconds_bucket{name="cluster",le="1e-06"} 0
workqueue_queue_duration_seconds_bucket{name="cluster",le="9.999999999999999e-06"} 17692
workqueue_queue_duration_seconds_bucket{name="cluster",le="9.999999999999999e-05"} 22538

@RainbowMango
Copy link
Member

Thanks.
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 0ab7333 into karmada-io:master Oct 20, 2021
@RainbowMango RainbowMango mentioned this pull request Oct 28, 2021
6 tasks
@Garrybest Garrybest mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants