Add event for cluster controller #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/M
pigletfly
force-pushed
the
cluster-controller-event
branch
from
a16e329 to
812b147
Compare
karmada-bot
added
size/S
pigletfly
force-pushed
the
cluster-controller-event
branch
from
812b147 to
810b2ba
Compare
karmada-bot
added
size/XS
pigletfly
force-pushed
the
cluster-controller-event
branch
from
810b2ba to
bbed507
Compare
| @@ -113,6 +115,7 @@ func (c *Controller) syncCluster(cluster *clusterv1alpha1.Cluster) (controllerru | |||
| // create execution space | |||
| err := c.createExecutionSpace(cluster) | |||
| if err != nil { | |||
| c.EventRecorder.Event(cluster, corev1.EventTypeWarning, fmt.Sprintf("Failed %s", eventTypeCreateExecutionNamespace), err.Error()) | |||
There was a problem hiding this comment.
Suggested change
| c.EventRecorder.Event(cluster, corev1.EventTypeWarning, fmt.Sprintf("Failed %s", eventTypeCreateExecutionNamespace), err.Error()) | |
| c.EventRecorder.Event(cluster, corev1.EventTypeWarning, eventReasonCreateExecutionNamespaceFailed, err.Error()) |
The reason might be proceeded by computer, so keep it short and clean.
|
cc @pigletfly |
karmada-bot
added
the
priority/important-soon
|
/remove-kind cleanup |
karmada-bot
added
kind/feature
Signed-off-by: pigletfly <[email protected]>
pigletfly
force-pushed
the
cluster-controller-event
branch
from
bbed507 to
3e1d447
Compare
|
/lgtm |
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pigletfly [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of ##398
Special notes for your reviewer:
Does this PR introduce a user-facing change?: