introduce --leader-elect-resource-namespace flag #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
pigletfly
suggested changes
Sep 6, 2021
XiShanYongYe-Chang
force-pushed
the
configure-ns
branch
from
4073491 to
ae1765e
Compare
|
/lgtm |
…rable Signed-off-by: changzhen <[email protected]>
XiShanYongYe-Chang
force-pushed
the
configure-ns
branch
from
ae1765e to
97f89f6
Compare
|
/retitle introduce --leader-elect-resource-namespace flag |
karmada-bot
changed the title
RainbowMango
added
the
release-note
|
Hi @pigletfly |
|
/lgtm |
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
OK. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: changzhen [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
User may want to deploy karmada to different namespace, so it makes sense to change
Options.LeaderElection.ResourceNamespaceto be configurable.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: