helm install karmada components in order

[chaosi-zju]

What type of PR is this?

/kind feature
/kind flake

What this PR does / why we need it:

helm install karmada components in order, for detailed discussion, see issue #4917

Which issue(s) this PR fixes:

Fixes #4917

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.30%. Comparing base (c181917) to head (01ec281).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5010      +/-   ##
==========================================
- Coverage   53.32%   53.30%   -0.02%     
==========================================
  Files         253      253              
  Lines       20560    20560              
==========================================
- Hits        10964    10960       -4     
- Misses       8870     8875       +5     
+ Partials      726      725       -1     

Flag	Coverage Δ
unittests	53.30% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[calvin0327]

/assign

[chaosi-zju]

Now, our Chart Lint test CI just only runs 3 minutes, while previously need almost 17 minute because components restart for many times.

This means the installation time of helm method will be greatly shortened, and users who use helm method will get greatly improved installation experience.

previous:

now:

[liangyuanpeng]

Now, our Chart Lint test CI just only runs 3 minutes, while previously need almost 17 minute because compnonets restart for many times.

it's a big promote!

[chaosi-zju]

CC @RainbowMango

[calvin0327]

/lgtm

[RainbowMango]

@a7i Can you help to take a look?
The issue we are trying to address is that the components launched by Helm don't have a solid order, which will lead to components crashing during the installation, such as karmada-controller-manager crashes if it starts before the karmada-apiserver.

The approach of this PR is trying to add an init container to the components if it reply on others. I'm not sure if this is the best practice for Helm chart dealing with many components.

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[a7i]

@RainbowMango apologies for the delay in my response as I was traveling for work.

I reviewed the linked Issue and the approach here makes sense. Additionally, in my organization, we don't use Helm so the solution proposed addresses it in a generic fashion that works for all.

Thank you @chaosi-zju for this!