-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search add check member cluster api enable #4554
search add check member cluster api enable #4554
Conversation
Signed-off-by: huangyanfeng <[email protected]>
b12603d
to
b6ff5b8
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4554 +/- ##
==========================================
- Coverage 51.87% 51.82% -0.06%
==========================================
Files 243 244 +1
Lines 24181 24244 +63
==========================================
+ Hits 12545 12565 +20
- Misses 10955 10996 +41
- Partials 681 683 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @XiShanYongYe-Chang |
Please take a look, thanks @XiShanYongYe-Chang |
Ok, I will take a look ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks~
Ask @ikaven1024 to help take a review.
/cc @ikaven1024
Ok, I will take a look ASAP. |
/lgtm |
Hi @yanfeng1992, can you help add the release note? |
how about this?@XiShanYongYe-Chang |
How about this: Describe in more detail. |
ok |
Thanks~ |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We need to synchronize it with the previous three versions: release 1.6, 1.7 and 1.8. I see that the version you found is 1.5, are you still using version 1.5? |
we are still at version 1.5 |
Sorry for replying late. Our current strategy is to only maintain the latest three versions, version 1.5 may not be within the scope of synchronization. |
…k-of-#4554-upstream-release-1.7 Automated cherry pick of #4554: search add check member cluster api enable
…k-of-#4554-upstream-release-1.8 Automated cherry pick of #4554: search add check member cluster api enable
…k-of-#4554-upstream-release-1.6 Automated cherry pick of #4554: search add check member cluster api enable
What type of PR is this?
/kind bug
What this PR does / why we need it:
When crd exists in the karmada control plane but does not exist in the member cluster, search will report an error.
Checks for member crd should be added
karmada version: 1.5
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: