Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search add check member cluster api enable #4554

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented Jan 16, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

When crd exists in the karmada control plane but does not exist in the member cluster, search will report an error.
Checks for member crd should be added

karmada version: 1.5

image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-search`: Add the logic of checking whether the resource API to be retrieved is installed in the cluster.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2024
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (04779a2) 51.87% compared to head (b6ff5b8) 51.82%.
Report is 75 commits behind head on master.

Files Patch % Lines
pkg/search/proxy/controller.go 14.28% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4554      +/-   ##
==========================================
- Coverage   51.87%   51.82%   -0.06%     
==========================================
  Files         243      244       +1     
  Lines       24181    24244      +63     
==========================================
+ Hits        12545    12565      +20     
- Misses      10955    10996      +41     
- Partials      681      683       +2     
Flag Coverage Δ
unittests 51.82% <14.28%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanfeng1992
Copy link
Member Author

/assign @XiShanYongYe-Chang

@yanfeng1992
Copy link
Member Author

Please take a look, thanks @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

Please take a look, thanks @XiShanYongYe-Chang

Ok, I will take a look ASAP.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks~

Ask @ikaven1024 to help take a review.
/cc @ikaven1024

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@ikaven1024
Copy link
Member

/lgtm Thanks~

Ask @ikaven1024 to help take a review. /cc @ikaven1024

Ok, I will take a look ASAP.

@ikaven1024
Copy link
Member

/lgtm

@XiShanYongYe-Chang
Copy link
Member

Hi @yanfeng1992, can you help add the release note?

@yanfeng1992
Copy link
Member Author

yanfeng1992 commented Jan 22, 2024

karmada-search : search add check member cluster api enable

how about this?@XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

XiShanYongYe-Chang commented Jan 22, 2024

How about this: karmada-search: Add the logic of checking whether the resource API to be retrieved is installed in the cluster.?

Describe in more detail.

@yanfeng1992
Copy link
Member Author

How about this: karmada-search: Add the logic of checking whether the resource API to be retrieved is installed in the cluster.?

Describe in more detail.

ok

@XiShanYongYe-Chang
Copy link
Member

Thanks~
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@karmada-bot karmada-bot merged commit d508417 into karmada-io:master Jan 23, 2024
12 checks passed
@XiShanYongYe-Chang
Copy link
Member

We need to synchronize it with the previous three versions: release 1.6, 1.7 and 1.8. I see that the version you found is 1.5, are you still using version 1.5?

@yanfeng1992
Copy link
Member Author

are you still using version 1.5?

we are still at version 1.5

@XiShanYongYe-Chang
Copy link
Member

we are still at version 1.5

Sorry for replying late. Our current strategy is to only maintain the latest three versions, version 1.5 may not be within the scope of synchronization.

karmada-bot added a commit that referenced this pull request Jan 29, 2024
…k-of-#4554-upstream-release-1.7

Automated cherry pick of #4554: search add check member cluster api enable
karmada-bot added a commit that referenced this pull request Jan 29, 2024
…k-of-#4554-upstream-release-1.8

Automated cherry pick of #4554: search add check member cluster api enable
karmada-bot added a commit that referenced this pull request Jan 29, 2024
…k-of-#4554-upstream-release-1.6

Automated cherry pick of #4554: search add check member cluster api enable
@yanfeng1992 yanfeng1992 deleted the fix-member-apienable branch April 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants