-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump golang.org/x/tools to v0.16.1 #4473
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4473 +/- ##
==========================================
- Coverage 51.87% 51.87% -0.01%
==========================================
Files 243 243
Lines 24179 24179
==========================================
- Hits 12543 12542 -1
- Misses 10954 10955 +1
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix for golang 1.22 and karmada currently uses 1.20, but a version upgrade will not hurt.
Signed-off-by: zhzhuang-zju <[email protected]>
Does that mean the |
They will cause panic in certain scenarios, but whether Karmada will encounter these scenarios remains to be known through experiments. |
The root cause is the implementation of See Go1.22 release notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumping tools to include the fix for a nil pointer deref error in go/types. See golang/go#64812 for more details.
This fix may be needed for when we bump to go1.22. See kubernetes/kubernetes#122412 for more details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: