Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang.org/x/tools to v0.16.1 #4473

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Bumping tools to include the fix for a nil pointer deref error in go/types. See golang/go#64812 for more details.
This fix may be needed for when we bump to go1.22. See kubernetes/kubernetes#122412 for more details.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 25, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (715d46c) 51.87% compared to head (f2e02a4) 51.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4473      +/-   ##
==========================================
- Coverage   51.87%   51.87%   -0.01%     
==========================================
  Files         243      243              
  Lines       24179    24179              
==========================================
- Hits        12543    12542       -1     
- Misses      10954    10955       +1     
  Partials      682      682              
Flag Coverage Δ
unittests 51.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix for golang 1.22 and karmada currently uses 1.20, but a version upgrade will not hurt.

@RainbowMango
Copy link
Member

This fix may be needed for when we bump to go1.22. See kubernetes/kubernetes#122412 for more details.

Does that mean the golang.org/x/tools before v0.16.1 is not compatible with go1.22?

@zhzhuang-zju
Copy link
Contributor Author

Does that mean the golang.org/x/tools before v0.16.1 is not compatible with go1.22?

They will cause panic in certain scenarios, but whether Karmada will encounter these scenarios remains to be known through experiments.

@RainbowMango
Copy link
Member

The root cause is the implementation of SizeFor has been adjusted in Go1.22, which is not compatible with golang.org/x/tools before v0.16.1.

See Go1.22 release notes:

The implementation of SizesFor has been adjusted to compute the same type sizes as the compiler when the compiler argument for SizesFor is "gc". The default Sizes implementation used by the type checker is now types.SizesFor("gc", "amd64").

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2023
@karmada-bot karmada-bot merged commit d17faec into karmada-io:master Dec 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants