Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick of #4338: fix incorrect forType in clusterResourceBinding status controller #4365

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

lxtywypc
Copy link
Contributor

@lxtywypc lxtywypc commented Dec 4, 2023

What type of PR is this?

What this PR does / why we need it:
Cherry-pick of #4338 on branch release-1.8

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: fix incorrect `forType` in `cluster-resource-binding-status controller` from `ResouceBinding` to `ClusterResourceBinding`

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@lxtywypc
Copy link
Contributor Author

lxtywypc commented Dec 4, 2023

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a330aa1) 51.80% compared to head (359fafe) 51.79%.

Files Patch % Lines
pkg/controllers/status/crb_status_controller.go 0.00% 1 Missing ⚠️
pkg/controllers/status/rb_status_controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8    #4365      +/-   ##
===============================================
- Coverage        51.80%   51.79%   -0.01%     
===============================================
  Files              243      243              
  Lines            24112    24112              
===============================================
- Hits             12491    12490       -1     
- Misses           10941    10942       +1     
  Partials           680      680              
Flag Coverage Δ
unittests 51.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@karmada-bot karmada-bot merged commit 1f0fb52 into karmada-io:release-1.8 Dec 4, 2023
12 checks passed
@lxtywypc lxtywypc deleted the cherry-pick-4338 branch December 26, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants