Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmada-operator: fixed operator manifests format #4318

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

calvin0327
Copy link

@calvin0327 calvin0327 commented Nov 24, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

image

Found a tab character that violates indentation.

fixed operator manifests format.

Which issue(s) this PR fixes:

The origin pr: #4198

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-operator`: Fixed an issue that components can not be deployed due to invalid manifests.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 24, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2023
@calvin0327 calvin0327 changed the title fixed operator manifests format karmada-operator: fixed operator manifests format Nov 24, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b8a7f7) 52.00% compared to head (8ae84c7) 52.00%.
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4318   +/-   ##
=======================================
  Coverage   52.00%   52.00%           
=======================================
  Files         242      242           
  Lines       23993    23984    -9     
=======================================
- Hits        12478    12474    -4     
+ Misses      10834    10830    -4     
+ Partials      681      680    -1     
Flag Coverage Δ
unittests 52.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this issue exists in karmadactl init and chart.

/lgtm
/approve

This reminds me we need to setup the CI for operator...

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@calvin0327
Copy link
Author

Please check if this issue exists in karmadactl init and chart.

/lgtm /approve

This reminds me we need to setup the CI for operator...

Yes, I have checked and only operator has this problem.

@karmada-bot karmada-bot merged commit f6b9849 into karmada-io:master Nov 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants