-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmada-operator: fixed operator manifests format #4318
Conversation
Signed-off-by: calvin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4318 +/- ##
=======================================
Coverage 52.00% 52.00%
=======================================
Files 242 242
Lines 23993 23984 -9
=======================================
- Hits 12478 12474 -4
+ Misses 10834 10830 -4
+ Partials 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if this issue exists in karmadactl init
and chart
.
/lgtm
/approve
This reminds me we need to setup the CI for operator...
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, I have checked and only operator has this problem. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Found a
tab character
that violates indentation.fixed operator manifests format.
Which issue(s) this PR fixes:
The origin pr: #4198
Special notes for your reviewer:
Does this PR introduce a user-facing change?: