-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix karmada instance aggregated service externalName error #4210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4210 +/- ##
=======================================
Coverage 52.83% 52.84%
=======================================
Files 239 239
Lines 23558 23558
=======================================
+ Hits 12448 12450 +2
+ Misses 10433 10432 -1
+ Partials 677 676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/reset e2e |
/lgtm |
I think we need release notes:
|
done |
Signed-off-by: wawa0210 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
LGTM
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix the latest Karmada-operator cannot install karmada instance
Which issue(s) this PR fixes:
Fixes #4209
Two bugs fixed in this pr
the example instance yaml
the results
Special notes for your reviewer:
Does this PR introduce a user-facing change?: