Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4144: fix: cannot access ResourceRegistry with its singularName #4154

Conversation

Yan-Daojiang
Copy link
Contributor

@Yan-Daojiang Yan-Daojiang commented Oct 20, 2023

Cherry pick of #4144 on release-1.6.
#4144: fix: cannot access ResourceRegistry with its singularName
For details on the cherry pick process, see the cherry pick requests page.

`karmada-search`:  fix cannot access ResourceRegistry with its singularName.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign xishanyongye-chang after the PR has been reviewed.
You can assign the PR to them by writing /assign @xishanyongye-chang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d3f187c) 54.32% compared to head (d377c1f) 54.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.6    #4154   +/-   ##
============================================
  Coverage        54.32%   54.32%           
============================================
  Files              223      223           
  Lines            21303    21303           
============================================
  Hits             11572    11572           
  Misses            9106     9106           
  Partials           625      625           
Flag Coverage Δ
unittests 54.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/registry/search/storage/resourceregistry.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants