-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add proposal for promote-dependencies-automatically #4100
feat: Add proposal for promote-dependencies-automatically #4100
Conversation
3e01fdc
to
68b091c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4100 +/- ##
==========================================
+ Coverage 52.76% 52.79% +0.02%
==========================================
Files 239 239
Lines 23584 23584
==========================================
+ Hits 12445 12450 +5
+ Misses 10462 10458 -4
+ Partials 677 676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign |
68b091c
to
e0dc7e9
Compare
/cc @XiShanYongYe-Chang for checking |
@jwcesign: GitHub didn't allow me to request PR reviews from the following users: for, checking. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
Hi, @zhy76 Please add the behavior of meeting promoting failure(validation failed or other), and if part dependencies already exist, what should Karmada do? |
Thanks, I will refer to your suggestions~ |
996c29f
to
7b72b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other lgtm
Any more suggestions about port-forward? @chaunceyjiang |
/cc @chaunceyjiang Do you have any more suggestions? |
Thanks for your suggestions, I will modify. |
6d0cc42
to
48b8e9f
Compare
added, thanks~ |
/approve Thank you for your excellent work, @zhy76 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwcesign, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/lgtm |
I guess the robot missed the e2e test signal. I'll retrigger the tests again. |
Signed-off-by: zhy76 <[email protected]>
03e7b2f
to
4b3d286
Compare
I'm not sure why the robot hanging there. |
/lgtm |
Thanks~ |
What type of PR is this?
/kind feature
/kind documentation
What this PR does / why we need it:
Add proposal for promote-dependencies-automatically
Which issue(s) this PR fixes:
Part of #4036
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: