Fix to validate spec.types of MultiClusterService Webhook

[lonelyCZ]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix to validate spec.types of MultiClusterService Webhook

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @yike21 @XiShanYongYe-Chang

Does this PR introduce a user-facing change?:

`karmada-webhook`: Fixed to validate spec.types of MultiClusterService api.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (48b8e9f) 53.50% compared to head (30723ae) 53.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4096   +/-   ##
=======================================
  Coverage   53.50%   53.51%           
=======================================
  Files         234      234           
  Lines       23281    23281           
=======================================
+ Hits        12457    12459    +2     
+ Misses      10143    10142    -1     
+ Partials      681      680    -1     

Flag	Coverage Δ
unittests	53.51% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/webhook/multiclusterservice/validating.go	56.96% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yike21]

This was an oversight on my part earlier, thank you very much!
/lgtm

[RainbowMango]

Seems the CI failed because of can't create new clusters:

------------------------------
• [FAILED] [280.857 seconds]
[karmada-search] karmada search testing reconcile ResourceRegistry when clusters joined, updated when cluster joined [BeforeAll] [member clusters joined] could reconcile ResourceRegistry
  [BeforeAll] /home/runner/work/karmada/karmada/test/e2e/search_test.go:737
  [It] /home/runner/work/karmada/karmada/test/e2e/search_test.go:788

  Timeline >>
  STEP: Creating cluster: member-e2e-9rmq9 @ 10/04/23 07:15:20.585
  [FAILED] in [BeforeAll] - /home/runner/work/karmada/karmada/test/e2e/search_test.go:750 @ 10/04/23 07:20:01.432
  STEP: Removing ResourceRegistry() @ 10/04/23 07:20:01.437
  [FAILED] in [AfterAll] - /home/runner/work/karmada/karmada/test/e2e/framework/resourceregistry.go:27 @ 10/04/23 07:20:01.441
  << Timeline

https://github.com/karmada-io/karmada/actions/runs/6402483929/job/17379406759?pr=4096

Let's give it another try.

[XiShanYongYe-Chang]

Thanks @lonelyCZ, when the ports array is larger than the types array, a panic is triggered.
Can you help add the release note, and maybe we need to cherry-pick it to the previous branch,

[XiShanYongYe-Chang]

Seems the CI failed because of can't create new clusters:

------------------------------
• [FAILED] [280.857 seconds]
[karmada-search] karmada search testing reconcile ResourceRegistry when clusters joined, updated when cluster joined [BeforeAll] [member clusters joined] could reconcile ResourceRegistry
  [BeforeAll] /home/runner/work/karmada/karmada/test/e2e/search_test.go:737
  [It] /home/runner/work/karmada/karmada/test/e2e/search_test.go:788

  Timeline >>
  STEP: Creating cluster: member-e2e-9rmq9 @ 10/04/23 07:15:20.585
  [FAILED] in [BeforeAll] - /home/runner/work/karmada/karmada/test/e2e/search_test.go:750 @ 10/04/23 07:20:01.432
  STEP: Removing ResourceRegistry() @ 10/04/23 07:20:01.437
  [FAILED] in [AfterAll] - /home/runner/work/karmada/karmada/test/e2e/framework/resourceregistry.go:27 @ 10/04/23 07:20:01.441
  << Timeline

https://github.com/karmada-io/karmada/actions/runs/6402483929/job/17379406759?pr=4096

Let's give it another try.

The space of the CI node is insufficient. A new cluster cannot be created.
Decode the returned error code to obtain the specific error information:

docker: Error response from daemon: failed to copy files: userspace copy failed: write /var/lib/docker/volumes/2327c2e7db1d02182f9548a35cb698441826dee2e599d9ba9079c61a56d7f367/_data/lib/containerd/io.containerd.content.v1.content/blobs/sha256/742c09864161856ed0e0f64bc2bb789be72e4d10db60138442dfff8d0f3e1b9e: no space left on device.
See 'docker run --help'.

[lonelyCZ]

Can you help add the release note, and maybe we need to cherry-pick it to the previous branch,

Done. We need to cherry-pick it to v1.7. I will do it after this pr is merged.

[XiShanYongYe-Chang]

Hi @lonelyCZ, we have fixed the CI failed, can you help rebase the master branch?

[XiShanYongYe-Chang]

Thanks a lot
/lgtm

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

Hi @lonelyCZ, can you help cherry-pick this branch into the previous v1.7 branch?

[lonelyCZ]

Hi @lonelyCZ, can you help cherry-pick this branch into the previous v1.7 branch?

Ok, I will do it ASAP.