-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make pull cluster to be able to register with proxy-server #4076
make pull cluster to be able to register with proxy-server #4076
Conversation
Signed-off-by: huangyanfeng <[email protected]>
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4076 +/- ##
=======================================
Coverage 53.83% 53.84%
=======================================
Files 231 231
Lines 23062 23062
=======================================
+ Hits 12415 12417 +2
+ Misses 9970 9968 -2
Partials 677 677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Have you tested it?
Are you using karmadactl register
in your company? Just curious about it. :)
We did not use karmadactl directly. We used the logic of karmadactl register in our multi-cluster-operator to implement the join pull cluster, and used the logic of karmadactl join to implement the join push cluster.
Deployed karmada agent and anp agent in the member cluster Deployed anpserver in the host cluster member cluster join successful Member cluster resources can be accessed through the karmada proxy function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
make pull cluster to be able to register with proxy-server
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: