Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pull cluster to be able to register with proxy-server #4076

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented Sep 19, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

make pull cluster to be able to register with proxy-server

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Introduced `--proxy-server-address` flag to `register` command to declare proxy server during registering a cluster.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 19, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (7c76237) 53.83% compared to head (d8a7d89) 53.84%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4076   +/-   ##
=======================================
  Coverage   53.83%   53.84%           
=======================================
  Files         231      231           
  Lines       23062    23062           
=======================================
+ Hits        12415    12417    +2     
+ Misses       9970     9968    -2     
  Partials      677      677           
Flag Coverage Δ
unittests 53.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have you tested it?

Are you using karmadactl register in your company? Just curious about it. :)

@yanfeng1992
Copy link
Member Author

yanfeng1992 commented Sep 19, 2023

@RainbowMango

Are you using karmadactl register in your company?

We did not use karmadactl directly. We used the logic of karmadactl register in our multi-cluster-operator to implement the join pull cluster, and used the logic of karmadactl join to implement the join push cluster.

Have you tested it?

Deployed karmada agent and anp agent in the member cluster

image

Deployed anpserver in the host cluster

image

member cluster join successful

image

image

Member cluster resources can be accessed through the karmada proxy function

image

@RainbowMango RainbowMango added this to the v1.8 milestone Sep 20, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@karmada-bot karmada-bot merged commit d0f23b8 into karmada-io:master Sep 20, 2023
11 checks passed
@yanfeng1992 yanfeng1992 deleted the feature-pull-anpserver branch October 7, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants