-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kubenetes dependencies to v1.26.1 #3080
Conversation
Update controller-runtime to 0.14.2 Update cluster-api to latest commit Signed-off-by: RainbowMango <[email protected]>
Signed-off-by: RainbowMango <[email protected]>
Signed-off-by: RainbowMango <[email protected]>
Signed-off-by: RainbowMango <[email protected]>
Signed-off-by: RainbowMango <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3080 +/- ##
==========================================
+ Coverage 43.30% 43.58% +0.28%
==========================================
Files 208 208
Lines 19429 19468 +39
==========================================
+ Hits 8414 8486 +72
+ Misses 10550 10501 -49
- Partials 465 481 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
622a781
to
6865fd5
Compare
Signed-off-by: RainbowMango <[email protected]>
6865fd5
to
a1e8f16
Compare
I grouped the changes by commits, could you guys help to take a look?
This PR also adopts generic sets and fixed some static check warnings(I don't know why they become block warnings...) |
Sure. /assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XiShanYongYe-Chang for the IngressStatus part
LGMT
LGTM |
I verified the describe function locally, looks good: -bash-5.0# _output/bin/linux/amd64/karmadactl version
karmadactl version: version.Info{GitVersion:"v1.4.0-196-ga1e8f164", GitCommit:"a1e8f164cb249659be25de1fdde37f33ede92f46", GitTreeState:"clean", BuildDate:"2023-02-01T03:26:42Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"linux/am}
-bash-5.0# _output/bin/linux/amd64/karmadactl describe deployments/nginx -C=member1
Name: nginx
Namespace: default
CreationTimestamp: Wed, 01 Feb 2023 11:29:04 +0800
Labels: app=nginx
propagationpolicy.karmada.io/name=nginx-propagation
propagationpolicy.karmada.io/namespace=default
resourcebinding.karmada.io/key=687f7fb96f
work.karmada.io/name=nginx-687f7fb96f
work.karmada.io/namespace=karmada-es-member1 @lonelyCZ If you find anything that needs to be fixed, please send a new PR. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates Kubenetest dependencies to v1.26.1:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: