Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add livenessProbe for descheduler #1894

Merged
merged 1 commit into from
May 30, 2022

Conversation

AllenZMC
Copy link
Member

@AllenZMC AllenZMC commented May 26, 2022

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
add livenessProbe for descheduler
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 26, 2022
@karmada-bot karmada-bot requested review from Garrybest and pidb May 26, 2022 15:47
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 26, 2022
@Garrybest
Copy link
Member

Thanks.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@AllenZMC
Copy link
Member Author

/kind cleanup

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 29, 2022
@AllenZMC
Copy link
Member Author

/cc @RainbowMango

@karmada-bot karmada-bot requested a review from RainbowMango May 30, 2022 01:45
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@karmada-bot karmada-bot merged commit 1e1147c into karmada-io:master May 30, 2022
@AllenZMC AllenZMC deleted the healthz_descheduler branch June 1, 2022 01:59
@RainbowMango RainbowMango added this to the v1.3 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants