Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add livenes for karmada-scheduler #1890

Merged
merged 1 commit into from
May 28, 2022
Merged

Add livenes for karmada-scheduler #1890

merged 1 commit into from
May 28, 2022

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented May 26, 2022

/kind bug

And livenesProbe for karmada-scheduler

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 26, 2022
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2022
@prodanlabs
Copy link
Member

Thanks for your contribution.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2022
@RainbowMango
Copy link
Member

LGTM. But let's move this forward after v1.2 is released(this week).
Please let me know if you really want it included in v1.2 release.

Thanks, in advance for your understanding.

@my-git9
Copy link
Member Author

my-git9 commented May 26, 2022

LGTM. But let's move this forward after v1.2 is released(this week). Please let me know if you really want it included in v1.2 release.

Thanks, in advance for your understanding.

OK. Thanks, let‘s look forward to the 1.2 release

@RainbowMango
Copy link
Member

/remove-kind bug
/kind cleanup

/approve

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels May 28, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2022
@karmada-bot karmada-bot merged commit 4eba0e5 into karmada-io:master May 28, 2022
@RainbowMango RainbowMango added this to the v1.3 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pidb pidb Awaiting requested review from pidb

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@prodanlabs prodanlabs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Karmada Release 1.3
Status: Done
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@my-git9 @prodanlabs @RainbowMango @karmada-bot