Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] log more err info when wait resource exist on member clusters #1848

Merged
merged 1 commit into from
May 30, 2022

Conversation

XiShanYongYe-Chang
Copy link
Member

Signed-off-by: changzhen [email protected]

What type of PR is this?

/kind flake
/kind cleanup

What this PR does / why we need it:

Add more detailed error info to help us determine whether the abnormal running of the clusterClient when wait resource exist on the member clusters.

Which issue(s) this PR fixes:
Part of #1841

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/flake Categorizes issue or PR as related to a flaky test. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 20, 2022
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2022
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@karmada-bot karmada-bot merged commit 519a385 into karmada-io:master May 30, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-log-info branch May 31, 2022 09:36
@RainbowMango RainbowMango added this to the v1.3 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants