Rework "bugfix: resource binding not created occasionally" #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c770cc1. Signed-off-by: dddddai <[email protected]>
karmada-bot
added
release-note-none
karmada-bot
added
the
size/L
There was a problem hiding this comment.
Generally looks good to me.
@pigletfly Could you please take a look? We can take this as a quick fix solution and won't conflict with your proposal.
pkg/detector/detector.go
Outdated
| @@ -714,6 +721,14 @@ func (d *ResourceDetector) BuildClusterResourceBinding(object *unstructured.Unst | |||
| return binding, nil | |||
| } | |||
|
|
|||
| // AddWaiting adds object's key to waiting list. | |||
There was a problem hiding this comment.
The comment is not correct.
Signed-off-by: dddddai <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
There was a problem hiding this comment.
@dddddai Would like to cherry-pick the second PR to branch release-1.0?
karmada-bot
added a commit
that referenced
this pull request
Feb 21, 2022
cherry-pick #1368: "bugfix: resource binding not created occasionally"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The workaround in #1199 does not work with multiple workers, so this pr does 2 things
Which issue(s) this PR fixes:
Fixes #1195
Special notes for your reviewer:
Does this PR introduce a user-facing change?: