introduce --tls-min-version flag to karmada-webhook #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
requested review from
kevin-wangzefeng,
lonelyCZ and
RainbowMango
karmada-bot
added
release-note
carlory
force-pushed
the
introduce-tls-flag-to-webhook
branch
from
f8c8d7e to
fc698b9
Compare
carlory
force-pushed
the
introduce-tls-flag-to-webhook
branch
3 times, most recently
from
6b75281 to
f23ea9d
Compare
kubectl logs info:
386
--skip_headers If true, avoid header prefixes in the log messages
387
--skip_log_headers If true, avoid headers when opening log files
388
--stderrthreshold severity logs at or above this threshold go to stderr (default 2)
389
--tls-min-version string Minimum TLS version supported. Possible values: VersionTLS10, VersionTLS11, VersionTLS12, VersionTLS13. (default "VersionTLS13")
390
-v, --v Level number for the log level verbosity (default 0)
391
--vmodule moduleSpec comma-separated list of pattern=N settings for file-filtered logging
392
393
ada-webhook [command] --help" for more information about a command.
394
395
invalid TLSMinVersion VersionTLS13: expects 1.0, 1.1, 1.2, 1.3 or empty |
carlory
force-pushed
the
introduce-tls-flag-to-webhook
branch
from
f23ea9d to
9441e9c
Compare
Sorry my bad. |
Co-authored-by: Hongcai Ren <[email protected]> Signed-off-by: carlory <[email protected]>
carlory
force-pushed
the
introduce-tls-flag-to-webhook
branch
from
7f4eb96 to
403de9c
Compare
|
/cc @RainbowMango It's ready for review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Some users want to config the TLS MinVersion for karmada-webhook.
Which issue(s) this PR fixes:
Fixes #1272
Special notes for your reviewer:
Does this PR introduce a user-facing change?: