-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HookEnabled interface with resourceinterpreter #1269
Update HookEnabled interface with resourceinterpreter #1269
Conversation
Wait for #1253 |
042baf4
to
6d54156
Compare
6d54156
to
5632b0b
Compare
Signed-off-by: changzhen <[email protected]>
5632b0b
to
fc7616e
Compare
/cc @RainbowMango |
Let's invite @iawia002 to take a look. |
/cc @iawia002 Please help take a look :) |
Nice work! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: changzhen [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
HookEnabled
interface with resource interpreter feature can be refactored to need objectGVK instead of object parameter.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: