Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete missing step for working-with-anp #1241

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

Signed-off-by: changzhen [email protected]

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Complete missing step for working-with-anp.md. After deploying ANP, we need to add command flags cluster-api-endpoint and proxy-server-address for karmada-agent deployment.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 11, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2022
@XiShanYongYe-Chang
Copy link
Member Author

/cc @Tingtal

Hi, can you help review it?

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: Tingtal.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Tingtal

Hi, can you help review it?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/working-with-anp.md Outdated Show resolved Hide resolved
docs/working-with-anp.md Outdated Show resolved Hide resolved
@XiShanYongYe-Chang
Copy link
Member Author

XiShanYongYe-Chang commented Jan 13, 2022

@Tingtal thanks for your review :)

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@karmada-bot karmada-bot merged commit 9167f9b into karmada-io:master Jan 13, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the complete-missing-step branch January 13, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants