-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete missing step for working-with-anp #1241
Complete missing step for working-with-anp #1241
Conversation
4236848
to
fb56ac9
Compare
/cc @Tingtal Hi, can you help review it? |
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: Tingtal. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fb56ac9
to
4e4dde7
Compare
4e4dde7
to
c9735d0
Compare
@Tingtal thanks for your review :) |
Signed-off-by: changzhen <[email protected]>
c9735d0
to
b927925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: changzhen [email protected]
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Complete missing step for
working-with-anp.md
. After deploying ANP, we need to add command flagscluster-api-endpoint
andproxy-server-address
for karmada-agent deployment.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: