Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unreachable code #1206

Merged
merged 1 commit into from
Jan 4, 2022
Merged

remove unreachable code #1206

merged 1 commit into from
Jan 4, 2022

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 2, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

As #828 merged, this code block is never called.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 2, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2022
@carlory carlory force-pushed the fix-cluster-controller branch from d128f6f to da91752 Compare January 2, 2022 14:21
@RainbowMango
Copy link
Member

/remove-kind bug
/kind cleanup

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 4, 2022
@carlory
Copy link
Member Author

carlory commented Jan 4, 2022

/cc @mrlihanbo @XiShanYongYe-Chang

@karmada-bot karmada-bot requested a review from mrlihanbo January 4, 2022 01:55
@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@mrlihanbo
Copy link

/lgtm

@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@karmada-bot karmada-bot merged commit 8b3aefd into karmada-io:master Jan 4, 2022
@karmada-bot karmada-bot requested a review from prodanlabs January 5, 2022 02:06
@carlory carlory mentioned this pull request Jan 5, 2022
Closed
@carlory carlory deleted the fix-cluster-controller branch July 13, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garrybest Garrybest Awaiting requested review from Garrybest

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

@mrlihanbo mrlihanbo Awaiting requested review from mrlihanbo

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

Assignees

@mrlihanbo mrlihanbo

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @RainbowMango @XiShanYongYe-Chang @mrlihanbo @karmada-bot